Skip to content

Comments

Move to cibuildwheels#100

Merged
ocefpaf merged 2 commits intoTEOS-10:masterfrom
ocefpaf:cibuildwheel
Sep 12, 2022
Merged

Move to cibuildwheels#100
ocefpaf merged 2 commits intoTEOS-10:masterfrom
ocefpaf:cibuildwheel

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Sep 8, 2022

Not ready for review yet.

@DocOtak
Copy link
Contributor

DocOtak commented Sep 8, 2022

Awesome, I hope this works well.

@ocefpaf ocefpaf force-pushed the cibuildwheel branch 6 times, most recently from 5b0a0d5 to 727c3c9 Compare September 9, 2022 19:03
@ocefpaf ocefpaf changed the title try cibuildwheels Move to cibuildwheels Sep 9, 2022
@ocefpaf ocefpaf marked this pull request as ready for review September 9, 2022 19:31
@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 9, 2022

@efiring and @DocOtak I'd love a second set of eyes here. This will move our clunky way of building wheels to the modern cibuildwheel It also builds wheels for the M1/M2 chips and the unreleased Python 3.11 (thanks to the stable API we can build wheels using the RCs now).

@DocOtak
Copy link
Contributor

DocOtak commented Sep 9, 2022

I grabbed the build artifacts and tested the python 3.9 and 3.10 wheels on the metal of my M1 machine (no rosetta). Everything Just Worked™, even the tests pass which I didn't expect passing given the fun in #40.

@efiring
Copy link
Member

efiring commented Sep 10, 2022

I tested the python3.10 wheel on macosx x86-64, and that also passes. Looks good. The only question I have at this point is why the artifacts include Python 3.6 and 3.7. I think we can drop those now.

@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 12, 2022

The only question I have at this point is why the artifacts include Python 3.6 and 3.7. I think we can drop those now.

Indeed. I left the cibuildwheels defaults there and they deprecated things a bit slower than the official deprecation. GSW in the other hand kind of follow NEP29 b/c the numpy dependency. Dropping those now.

@ocefpaf ocefpaf requested a review from efiring September 12, 2022 14:03
@ocefpaf ocefpaf merged commit ae70dc7 into TEOS-10:master Sep 12, 2022
@ocefpaf ocefpaf deleted the cibuildwheel branch September 12, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants