Skip to content

Ensure the slice is an array #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiring merged 3 commits into from
Nov 29, 2022
Merged

Ensure the slice is an array #114

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13ab9cf
ensure the slice is an array
ocefpaf Nov 29, 2022
b38d621
review actions
ocefpaf Nov 29, 2022
99e6337
asarray
ocefpaf Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gsw/geostrophy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ def geo_strf_dyn_height(SA, CT, p, p_ref=0, axis=0, max_dp=1.0,
except AttributeError:
order = 'C' # e.g., xarray DataArray doesn't have flags
for ind in indexer(SA.shape, axis, order=order):
igood = goodmask[ind]
# this is needed to support xarray inputs for numpy < 1.23
igood = np.asarray(goodmask[ind])
# If p_ref is below the deepest value, skip the profile.
pgood = p[ind][igood]
if len(pgood) > 1 and pgood[-1] >= p_ref:
Expand Down