Skip to content

Comments

Closes 74#126

Merged
ocefpaf merged 10 commits intoTEOS-10:mainfrom
ocefpaf:closes_74
Apr 5, 2023
Merged

Closes 74#126
ocefpaf merged 10 commits intoTEOS-10:mainfrom
ocefpaf:closes_74

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Apr 3, 2023

Added a test to avoid regressions and pinned pandas to >=2 in our tests.
Note that pandas is not a direct dependency of gsw so in a way that bug is only fixed if the user updates their pandas.

I also moved all the metadata from setup.cfg to pyproject.toml to help consolidate the packaging with less files and a more modern approach. I'll try to do the same for the setup.py in a future PR. but compiled extensions are still hard to do in a consistent manner.

PS: I'll fix the lints in another PR this one is already too big for its own sake.

@ocefpaf ocefpaf marked this pull request as draft April 3, 2023 20:36
@ocefpaf ocefpaf marked this pull request as ready for review April 4, 2023 13:00
@ocefpaf ocefpaf requested a review from efiring April 4, 2023 13:00
@efiring
Copy link
Member

efiring commented Apr 4, 2023

It looks like ruff is finding some legacy things that could be cleaned up (but that don't hurt, so they are very low priority), and some things we probably don't want to change at all. Maybe the thing to do is to turn ruff off for now, so the rest of this changeset can be merged without leaving behind perpetual test failure.

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 4, 2023

without leaving behind perpetual test failure.

I'm planning on working on this as soon as this one is merged. I already have the changes locally, from fixes to file/test skips. Hopefully the failure won't be there for more than a day. But I can turn it off, merge and on again, no problem.

Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to go ahead with this as is.

@ocefpaf ocefpaf mentioned this pull request Apr 4, 2023
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 4, 2023

Fine to go ahead with this as is.

I pushed them here in case you have some free cycles to look at them (last commit) of #127

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 5, 2023

Follow up in #127. I don't want to make this PR too big and hard to follow.

@ocefpaf ocefpaf merged commit 30c5aa4 into TEOS-10:main Apr 5, 2023
@ocefpaf ocefpaf deleted the closes_74 branch April 5, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants