Conversation
ocefpaf
force-pushed
the
numpy_2
branch
7 times, most recently
from
cfe0b31 to
371b43c
Compare
ocefpaf
force-pushed
the
numpy_2
branch
2 times, most recently
from
0b9597e to
6c8c8d6
Compare
ocefpaf
commented
Apr 25, 2024
|
|
||
|
|
||
| @pytest.fixture(params=[-360, 0, 360]) | ||
| @pytest.fixture(params=[-360., 0., 360.]) |
Member
Author
There was a problem hiding this comment.
The hardest part was setting up the np2.0 test! This was the only failure we had due to https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotion
Member
Author
There was a problem hiding this comment.
@efiring this is the only code change in this PR. Everything else is to be able to set a testing matrix with numpy 2.0. This PR also adds a test for the code generation step that serves both as test and developer breadcrumbs in case we need to do that locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some significant changes in the next release. Hopefully it won't be too hard to port the code to it.