Skip to content

Comments

Add infunnel wrapper, simplify code generation#175

Merged
ocefpaf merged 5 commits intoTEOS-10:mainfrom
efiring:add_infunnel
Jul 23, 2024
Merged

Add infunnel wrapper, simplify code generation#175
ocefpaf merged 5 commits intoTEOS-10:mainfrom
efiring:add_infunnel

Conversation

@efiring
Copy link
Member

@efiring efiring commented Jul 21, 2024

Wrapping the infunnel function, with its int return, required enough change that I took the opportunity to re-write some of the code generation functions.

Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to run the code generation steps in the CIs in the future but we don't need to wait for that to merge this one.

@efiring
Copy link
Member Author

efiring commented Jul 23, 2024

You already have one CI run for code generation--do you mean run code generation for every build on every combination of versions and platforms? I'm not convinced that would be a good idea.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 23, 2024

You already have one CI run for code generation--do you mean run code generation for every build on every combination of versions and platforms? I'm not convinced that would be a good idea.

Nope. I forgot I already did that :-/
Sorry but lately my brain doesn't seem to be able to hold new information anymore.

@ocefpaf ocefpaf merged commit c340736 into TEOS-10:main Jul 23, 2024
@ocefpaf
Copy link
Member

ocefpaf commented Jul 23, 2024

@efiring are you OK with a new release? I can do that later today/tomorrow.

@efiring
Copy link
Member Author

efiring commented Jul 23, 2024

Yes, a release would be fine, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants