Conversation
ocefpaf
force-pushed
the
docs_gha
branch
3 times, most recently
from
b8ef26a to
34ca587
Compare
efiring
approved these changes
Feb 24, 2022
Member
efiring
left a comment
efiring
left a comment
There was a problem hiding this comment.
Just one minor potential correction.
.github/workflows/deploy-docs.yml
Outdated
| - name: Create environment | ||
| shell: bash -l {0} | ||
| run: | | ||
| conda create --name TEST python=3 python-build cython numpy --file requirements-dev.txt |
Member
Author
There was a problem hiding this comment.
Argh. That "copy-n-paste" error was there for a while. I removed it from everywhere now. Luckily it did not cause any side effect on the builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis-CI is unreliable lately and doctr does not work with GHA. This means we will not have the ability to publish versioned docs anymore. I don't think this is a big deal b/c the docstrings and API don't change that much. One can always builds previous version from tags themselves if they need to.