Skip to content

Comments

Correct Nsquared unit#91

Merged
efiring merged 4 commits intoTEOS-10:masterfrom
rcaneill:patch-1
May 20, 2022
Merged

Correct Nsquared unit#91
efiring merged 4 commits intoTEOS-10:masterfrom
rcaneill:patch-1

Conversation

@rcaneill
Copy link
Contributor

@rcaneill rcaneill commented Mar 8, 2022

The unit of Nsuared should be 1/s^2

@rcaneill rcaneill requested a review from ocefpaf May 19, 2022 07:35
@rcaneill
Copy link
Contributor Author

Any idea why the windows test does not pass?

@efiring
Copy link
Member

efiring commented May 19, 2022

The windows test failure is at the installation stage. Pip is installing a bunch of dependencies, and installation of pyparsing fails. I think all of these dependencies should be obtainable from conda-forge. In any case, it looks like some tweaking of the windows test setup will be needed.

@ocefpaf ocefpaf mentioned this pull request May 19, 2022
@ocefpaf
Copy link
Member

ocefpaf commented May 19, 2022

The windows test failure is at the installation stage. Pip is installing a bunch of dependencies, and installation of pyparsing fails. I think all of these dependencies should be obtainable from conda-forge. In any case, it looks like some tweaking of the windows test setup will be needed.

The problem is with latest pip. See conda-forge/pip-feedstock#94

PR conda-forge/admin-requests#439 should fix it.

@rcaneill
Copy link
Contributor Author

Damn it, the build and deploy action did not work... It says broken link but the links work for me... Maybe re-trigger this test manually?

@ocefpaf
Copy link
Member

ocefpaf commented May 20, 2022

Damn it, the build and deploy action did not work... It says broken link but the links work for me... Maybe re-trigger this test manually?

Don't worry. That is pretty minor, it is only the linkcheck telling us that the TEOS-10 site moved. I'll fix it in a bit. We can merge this without that check if @efiring is ok with the changes.

@ocefpaf ocefpaf mentioned this pull request May 20, 2022
@efiring efiring merged commit d75dfe5 into TEOS-10:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants