[REFACTOR] QA 반영 #111
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| package com.texthip.thip.ui.common.topappbar | ||
|
|
||
| import androidx.compose.animation.AnimatedVisibility | ||
| import androidx.compose.foundation.background | ||
| import androidx.compose.foundation.layout.Box | ||
| import androidx.compose.foundation.layout.Column | ||
|
|
@@ -9,6 +10,11 @@ import androidx.compose.foundation.layout.padding | |
| import androidx.compose.material3.Icon | ||
| import androidx.compose.material3.IconButton | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.runtime.LaunchedEffect | ||
| import androidx.compose.runtime.getValue | ||
| import androidx.compose.runtime.mutableStateOf | ||
| import androidx.compose.runtime.remember | ||
| import androidx.compose.runtime.setValue | ||
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.graphics.Brush | ||
|
|
@@ -20,14 +26,39 @@ import androidx.compose.ui.unit.dp | |
| import com.texthip.thip.R | ||
| import com.texthip.thip.ui.common.view.CountingBar | ||
| import com.texthip.thip.ui.theme.ThipTheme.colors | ||
| import kotlinx.coroutines.delay | ||
|
|
||
| @Composable | ||
| fun GradationTopAppBar( | ||
| isImageVisible: Boolean = false, | ||
| count: Int = 0, | ||
| autoHideCount: Boolean? = null, | ||
| countDisplayDurationMs: Long = 5000L, | ||
| onLeftClick: () -> Unit, | ||
| onRightClick: () -> Unit = {}, | ||
| ) { | ||
| var isCountVisible by remember { mutableStateOf(isImageVisible) } | ||
|
|
||
| // autoHideCount가 null이 아닐 때만 자동 숨김 로직 실행 | ||
| LaunchedEffect(autoHideCount, count) { | ||
| when (autoHideCount) { | ||
| true -> { | ||
| if (count > 0) { | ||
| isCountVisible = true | ||
| delay(countDisplayDurationMs) | ||
| isCountVisible = false | ||
| } | ||
| } | ||
| false -> { | ||
| isCountVisible = true | ||
| } | ||
| null -> { | ||
| // 기존 동작 유지: isImageVisible 파라미터 사용 | ||
| isCountVisible = isImageVisible | ||
| } | ||
| } | ||
| } | ||
|
|
||
| val bgColor = Brush.verticalGradient( | ||
| colors = listOf( | ||
| colors.Black, | ||
|
|
@@ -54,15 +85,17 @@ fun GradationTopAppBar( | |
| ) | ||
| } | ||
|
|
||
| Column { | ||
| AnimatedVisibility( | ||
| visible = isCountVisible && count > 0 | ||
| ) { | ||
| CountingBar( | ||
| content = stringResource(R.string.reading_user_num, count) | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| /*IconButton( | ||
| onClick = onRightClick, | ||
| modifier = Modifier.align(Alignment.CenterEnd) | ||
| ) { | ||
|
|
@@ -71,7 +104,7 @@ fun GradationTopAppBar( | |
| contentDescription = "More Options", | ||
| tint = Color.Unspecified | ||
| ) | ||
| }*/ | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,7 @@ fun LogoTopAppBar( | |
| val rightIcon = if (hasNotification) { | ||
| painterResource(R.drawable.ic_notice_yes) | ||
| } else { | ||
| painterResource(R.drawable.ic_notice_no) | ||
| } | ||
|
|
||
| Box( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| package com.texthip.thip.ui.feed.screen | ||
|
|
||
| import androidx.compose.animation.AnimatedVisibility | ||
| import androidx.compose.animation.core.tween | ||
| import androidx.compose.animation.slideInVertically | ||
| import androidx.compose.animation.slideOutVertically | ||
| import androidx.compose.foundation.background | ||
| import androidx.compose.foundation.clickable | ||
| import androidx.compose.foundation.gestures.detectTapGestures | ||
|
|
@@ -79,6 +83,7 @@ fun FeedCommentScreen( | |
| onNavigateBack: () -> Unit = {}, | ||
| onNavigateToFeedEdit: (Int) -> Unit = {}, | ||
| onNavigateToUserProfile: (userId: Long) -> Unit = {}, | ||
| onNavigateToBookDetail: (String) -> Unit = {}, | ||
| feedDetailViewModel: FeedDetailViewModel = hiltViewModel(), | ||
| commentsViewModel: CommentsViewModel = hiltViewModel() | ||
| ) { | ||
|
|
@@ -223,7 +228,9 @@ fun FeedCommentScreen( | |
| ActionBookButton( | ||
| bookTitle = feedDetail.bookTitle, | ||
| bookAuthor = feedDetail.bookAuthor, | ||
| onClick = { | ||
| onNavigateToBookDetail(feedDetail.isbn) | ||
| } | ||
| ) | ||
| } | ||
| Text( | ||
|
|
@@ -398,17 +405,27 @@ fun FeedCommentScreen( | |
| } | ||
| ) | ||
| } | ||
|
|
||
| // 신고 완료 토스트 | ||
| AnimatedVisibility( | ||
| visible = showToast, | ||
| enter = slideInVertically( | ||
| initialOffsetY = { -it }, | ||
| animationSpec = tween(durationMillis = 2000) | ||
| ), | ||
| exit = slideOutVertically( | ||
| targetOffsetY = { -it }, | ||
| animationSpec = tween(durationMillis = 2000) | ||
| ), | ||
| modifier = Modifier | ||
| .align(Alignment.TopCenter) | ||
| .padding(horizontal = 20.dp, vertical = 16.dp) | ||
| .zIndex(2f) | ||
| ) { | ||
| ToastWithDate( | ||
| message = "게시글 신고를 완료했어요." | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| if (isBottomSheetVisible) { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
저자명과 ‘저’를 분리한 건 👍. 다음 두 가지를 개선해 주세요 (현지화/접근성 친화).
TextAlign.Right대신TextAlign.End를 사용해 레이아웃 방향을 따른 정렬을 권장합니다.padding(start = …)로 간격을 주는 방식으로 정리하는 것을 권장합니다.아래 diff는 컴포넌트 내에서 가능한 최소 변경입니다(문자열 리소스의 선행 공백 제거가 전제되면 시각적 일관성이 좋아집니다).
추가로,
widthIn(max = 80.dp)는 폰트 스케일이 큰 환경에서 너무 촘촘할 수 있습니다. 필요시 96dp 정도로 여유를 주거나, 상황에 따라 조건부로 완화하는 것도 고려해 볼 수 있습니다.문자열 리소스에 선행 공백이나 따옴표가 포함되어 있는지 확인해 주세요. 포함되어 있다면 제거하는 것을 권장합니다.
🏁 Script executed:
Length of output: 192
RTL 정렬 및 문자열 리소스 정리 필수 반영
•
TextAlign.Right→TextAlign.End(RTL 안전 정렬)• 두 번째
Text에Modifier.padding(start = 4.dp)추가 (문자열 리소스에 공백 제거)• (선택) 첫 번째
Text의widthIn(max = 80.dp)를96.dp로 여유 부여 고려•
<string name="author">" 저"</string>→<string name="author">저</string>🤖 Prompt for AI Agents