Skip to content

[chore] 운영서버로 배포 25/08/13#212

Merged
hd0rable merged 38 commits into
mainfrom
develop
Aug 13, 2025
Merged

[chore] 운영서버로 배포 25/08/13#212
hd0rable merged 38 commits into
mainfrom
develop

Conversation

@hd0rable
Copy link
Copy Markdown
Member

@hd0rable hd0rable commented Aug 13, 2025

#️⃣ 연관된 이슈

closes #이슈번호

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

📸 스크린샷

💬 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

📌 PR 진행 시 이러한 점들을 참고해 주세요

* P1 : 꼭 반영해 주세요 (Request Changes) - 이슈가 발생하거나 취약점이 발견되는 케이스 등
* P2 : 반영을 적극적으로 고려해 주시면 좋을 것 같아요 (Comment)
* P3 : 이런 방법도 있을 것 같아요~ 등의 사소한 의견입니다 (Chore)

Summary by CodeRabbit

  • New Features
    • 피드 작성 화면 정보 조회 API 추가(/feeds/write-info): 카테고리별 태그 목록 제공 및 캐시 적용.
    • 기록 고정 API 추가(/rooms/{roomId}/records/{recordId}/pin): 방 피드에 기록 고정, 응답으로 도서 정보 제공.
  • Documentation
    • Swagger에 RECORD_PIN 오류 설명 및 신규 엔드포인트 문서화.
  • Refactor
    • 트랜잭션 어노테이션을 Spring 기반으로 통일.
  • Tests
    • 신규 API 통합 테스트와 기록 고정 도메인 검증 테스트 추가.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

여러 서비스에서 트랜잭션 어노테이션을 Spring으로 전환했다. 피드 작성 화면용 조회 API와 태그 조회/매핑/캐시 로직을 추가했다. 기록 핀 고정 API를 도입하여 도메인 검증, 응답 DTO, Swagger 응답 상수, 테스트를 포함해 컨트롤러·서비스·포트를 확장했다.

Changes

Cohort / File(s) Summary
Transactional import 전환
src/main/java/konkuk/thip/book/application/service/BookSavedService.java, .../comment/application/service/CommentDeleteService.java, .../comment/application/service/CommentLikeService.java, .../feed/application/service/FeedDeleteService.java, .../feed/application/service/FeedSavedService.java, .../post/application/service/PostLikeService.java, .../record/application/service/RecordCreateService.java, .../record/application/service/RecordDeleteService.java
jakarta.transaction.Transactional → org.springframework.transaction.annotation.Transactional로 import 교체. 로직·시그니처 변화 없음.
Feed 작성 정보 조회 기능
.../feed/adapter/in/web/FeedQueryController.java, .../feed/adapter/in/web/response/FeedShowWriteInfoResponse.java, .../feed/adapter/out/persistence/FeedQueryPersistenceAdapter.java, .../feed/adapter/out/persistence/repository/FeedQueryRepository.java, .../feed/adapter/out/persistence/repository/FeedQueryRepositoryImpl.java, .../feed/application/mapper/FeedQueryMapper.java, .../feed/application/port/in/FeedShowWriteInfoUseCase.java, .../feed/application/port/in/dto/TagsWithCategoryResult.java, .../feed/application/port/out/FeedQueryPort.java, .../feed/application/port/out/dto/TagCategoryQueryDto.java, .../feed/application/service/FeedShowWriteInfoService.java, src/test/java/konkuk/thip/feed/adapter/in/web/FeedShowWriteInfoAPITest.java
GET /feeds/write-info 추가. 태그 카테고리/태그 전체 조회 쿼리, QueryDSL DTO/프로젝션, 그룹핑 매퍼, 캐시(@Cacheable), UseCase/Service/Port/Repo 확장 및 통합 테스트 추가.
Record 핀 고정 기능
.../record/adapter/in/web/RecordQueryController.java, .../record/adapter/in/web/response/RecordPinResponse.java, .../record/application/port/in/RecordPinUseCase.java, .../record/application/port/in/dto/RecordPinQuery.java, .../record/application/service/RecordPinService.java, .../record/domain/Record.java, .../common/swagger/SwaggerResponseDescription.java, src/test/java/konkuk/thip/record/adapter/in/web/RecordPinAPITest.java, src/test/java/konkuk/thip/record/domain/RecordTest.java
GET /rooms/{roomId}/records/{recordId}/pin 추가. 핀 검증 도메인 메서드/메시지 보강, Swagger RECORD_PIN 상수 추가, 응답 DTO/UseCase/Service 구현, 권한·존재 검증 흐름 및 통합/단위 테스트 추가.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Client
  participant Controller as FeedQueryController
  participant UseCase as FeedShowWriteInfoUseCase
  participant Service as FeedShowWriteInfoService
  participant Port as FeedQueryPort
  participant Repo as FeedQueryRepository
  participant Mapper as FeedQueryMapper
  Client->>Controller: GET /feeds/write-info
  Controller->>UseCase: showFeedWriteInfo()
  UseCase->>Service: delegate
  Service->>Port: findAllTags()
  Port->>Repo: findAllTags()
  Repo-->>Port: List<TagCategoryQueryDto>
  Port-->>Service: rows
  Service->>Mapper: toTagsWithCategoryResult(rows)
  Mapper-->>Service: List<TagsWithCategoryResult>
  Service-->>Controller: FeedShowWriteInfoResponse
  Controller-->>Client: 200 OK + BaseResponse
Loading
sequenceDiagram
  autonumber
  actor Client
  participant Controller as RecordQueryController
  participant UseCase as RecordPinUseCase
  participant Service as RecordPinService
  participant Validator as RoomParticipantValidator
  participant RecordPort as RecordCommandPort
  participant BookPort as BookCommandPort
  participant Mapper as BookQueryMapper
  Client->>Controller: GET /rooms/{roomId}/records/{recordId}/pin (userId)
  Controller->>UseCase: pinRecord(query)
  UseCase->>Service: delegate
  Service->>Validator: validateUserIsRoomMember(roomId, userId)
  Service->>RecordPort: getByIdOrThrow(recordId)
  RecordPort-->>Service: Record
  Service->>Record: validatePin(userId, roomId)
  Service->>BookPort: findBookByRoomId(roomId)
  BookPort-->>Service: Book
  Service->>Mapper: toBookSelectableResult(Book)
  Mapper-->>Service: BookSelectableResult
  Service-->>Controller: RecordPinResponse.of(...)
  Controller-->>Client: 200 OK + BaseResponse
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested labels

🛠️ feat, 🧸 현준

Suggested reviewers

  • seongjunnoh
  • buzz0331

Poem

( )_( ) hop!
(='x'=) 태그를 주워 바구니에 쏙—
피드 쓰기 길 안내, 깔끔히 정리했지.
기록은 핀으로 톡, 방 한켠 빛나네.
트랜잭션 길도 갈아타고,
오늘도 코드는 폴짝 안정! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac8f682 and 3b7b536.

📒 Files selected for processing (29)
  • src/main/java/konkuk/thip/book/application/service/BookSavedService.java (1 hunks)
  • src/main/java/konkuk/thip/comment/application/service/CommentDeleteService.java (1 hunks)
  • src/main/java/konkuk/thip/comment/application/service/CommentLikeService.java (1 hunks)
  • src/main/java/konkuk/thip/common/swagger/SwaggerResponseDescription.java (1 hunks)
  • src/main/java/konkuk/thip/feed/adapter/in/web/FeedQueryController.java (3 hunks)
  • src/main/java/konkuk/thip/feed/adapter/in/web/response/FeedShowWriteInfoResponse.java (1 hunks)
  • src/main/java/konkuk/thip/feed/adapter/out/persistence/FeedQueryPersistenceAdapter.java (2 hunks)
  • src/main/java/konkuk/thip/feed/adapter/out/persistence/repository/FeedQueryRepository.java (2 hunks)
  • src/main/java/konkuk/thip/feed/adapter/out/persistence/repository/FeedQueryRepositoryImpl.java (2 hunks)
  • src/main/java/konkuk/thip/feed/application/mapper/FeedQueryMapper.java (2 hunks)
  • src/main/java/konkuk/thip/feed/application/port/in/FeedShowWriteInfoUseCase.java (1 hunks)
  • src/main/java/konkuk/thip/feed/application/port/in/dto/TagsWithCategoryResult.java (1 hunks)
  • src/main/java/konkuk/thip/feed/application/port/out/FeedQueryPort.java (2 hunks)
  • src/main/java/konkuk/thip/feed/application/port/out/dto/TagCategoryQueryDto.java (1 hunks)
  • src/main/java/konkuk/thip/feed/application/service/FeedDeleteService.java (1 hunks)
  • src/main/java/konkuk/thip/feed/application/service/FeedSavedService.java (1 hunks)
  • src/main/java/konkuk/thip/feed/application/service/FeedShowWriteInfoService.java (1 hunks)
  • src/main/java/konkuk/thip/post/application/service/PostLikeService.java (1 hunks)
  • src/main/java/konkuk/thip/record/adapter/in/web/RecordQueryController.java (3 hunks)
  • src/main/java/konkuk/thip/record/adapter/in/web/response/RecordPinResponse.java (1 hunks)
  • src/main/java/konkuk/thip/record/application/port/in/RecordPinUseCase.java (1 hunks)
  • src/main/java/konkuk/thip/record/application/port/in/dto/RecordPinQuery.java (1 hunks)
  • src/main/java/konkuk/thip/record/application/service/RecordCreateService.java (2 hunks)
  • src/main/java/konkuk/thip/record/application/service/RecordDeleteService.java (1 hunks)
  • src/main/java/konkuk/thip/record/application/service/RecordPinService.java (1 hunks)
  • src/main/java/konkuk/thip/record/domain/Record.java (2 hunks)
  • src/test/java/konkuk/thip/feed/adapter/in/web/FeedShowWriteInfoAPITest.java (1 hunks)
  • src/test/java/konkuk/thip/record/adapter/in/web/RecordPinAPITest.java (1 hunks)
  • src/test/java/konkuk/thip/record/domain/RecordTest.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

Test Results

383 tests   383 ✅  33s ⏱️
113 suites    0 💤
113 files      0 ❌

Results for commit 3b7b536.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant