[deploy] 운영서버로 배포 25/08/16#235
Merged
Merged
Conversation
- 방장에 해당하는 RoomParticipant create & DB save 하는 코드 추가
- RoomParticipantRepository 의존성 추가 - RoomParticipant DB save 되는지 확인하는 테스트 코드 추가
- 투표 생성한 사람의 userPercentage 값 수정 - 해당 방의 roomPercentage 값 수정 (기록 생성 서비스 코드 참고하였습니다)
…비스 통합 테스트 코드 작성 (#181)
[refactor] 기록장 조회 api 리팩토링
- 커서 기반 페이지네이션에 맞게 응답 데이터 수정
- 커서 기반 페이지네이션으로 수정 - 우선순위 조건 제거 - 반환타입으로 QueryProjection 도입
- 방 검색을 위해 Projection 생성자 추가
- 함수형 인터페이스 추가로 생성 (Integer를 커서로 활용할 수 있도록)
…65) - room과 left join이 아니라, inner join을 강제할 수 있도록 (for 성능 개선)
- 카테고리, 정렬 조건 값에 따라서 분기처리 후 그에 맞는 query port 메서드 호출하도록 구현
[hotfix] 방 검색 api 수정
…e-response [hotfix] 피드 단일 조회 response 수정
|
Caution Review failedThe pull request is closed. WalkthroughCD 트리거 브랜치에 develop 추가, Docker JVM 옵션 설정. OpenAPI 서버 구성이 profile 기반으로 변경. “오늘의 한마디” 기능을 room.*로 이관·구현(도메인/포트/어댑터/컨트롤러). 방 검색을 커서 기반 API로 전면 개편. 투표 삭제 API·도메인 검증·리포지토리 삭제 경로 추가. 댓글/피드/레코드 응답 확장(isWriter/isOverview). 기타 ACTIVE 상태 필터링, 유저 가입 검증 보강 등. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant RC as RoomCommandController
participant ACU as AttendanceCheckCreateUseCase
participant AQS as AttendanceCheckQueryPort
participant ACS as AttendanceCheckCommandPort
U->>RC: POST /rooms/{roomId}/daily-greeting (content)
RC->>ACU: create(command)
ACU->>AQS: countAttendanceChecksOnTodayByUser(userId, roomId)
AQS-->>ACU: count
ACU->>ACS: save(AttendanceCheck.withoutId(..., count))
ACS-->>ACU: attendanceCheckId
ACU-->>RC: AttendanceCheckCreateResult
RC-->>U: BaseResponse(AttendanceCheckCreateResponse)
sequenceDiagram
autonumber
actor U as User
participant VC as VoteCommandController
participant VDS as VoteDeleteService
participant VP as VoteCommandPort
participant CC as CommentCommandPort
participant PLC as PostLikeCommandPort
U->>VC: DELETE /rooms/{roomId}/vote/{voteId}
VC->>VDS: deleteVote(command)
VDS->>VP: getByIdOrThrow(voteId)
VDS->>VP: (domain) validateDeletable(userId, roomId)
VDS->>CC: softDeleteAllByPostId(voteId)
VDS->>PLC: deleteAllByPostId(voteId)
VDS->>VP: delete(vote)
VDS-->>VC: roomId
VC-->>U: BaseResponse(VoteDeleteResponse)
sequenceDiagram
autonumber
actor U as User
participant RQ as RoomQueryController
participant RS as RoomSearchUseCase
participant RQP as RoomQueryPort
participant RQM as RoomQueryMapper
U->>RQ: GET /rooms/search?cursor=...
RQ->>RS: searchRecruitingRooms(RoomSearchQuery)
RS->>RQP: searchRecruitingRooms* (by sort/category, Cursor)
RQP-->>RS: CursorBasedList<RoomQueryDto>
RS->>RQM: toRoomSearchResponse(dtos)
RQM-->>RS: List<RoomSearchDto>
RS-->>RQ: RoomSearchResponse(nextCursor,isLast)
RQ-->>U: Response
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120+ minutes Possibly related PRs
Suggested labels
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This was referenced Aug 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
📸 스크린샷
💬 리뷰 요구사항
📌 PR 진행 시 이러한 점들을 참고해 주세요
Summary by CodeRabbit