[refactor] 피드 저장 시 일급컬렉션이 아닌 boolean으로 저장 여부 조회 #250
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,11 +4,12 @@ | |
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.data.jpa.repository.Modifying; | ||
| import org.springframework.data.jpa.repository.Query; | ||
| import org.springframework.data.repository.query.Param; | ||
|
|
||
| public interface SavedBookJpaRepository extends JpaRepository<SavedBookJpaEntity, Long> { | ||
| @Query("SELECT CASE WHEN COUNT(s) > 0 THEN true ELSE false END FROM SavedBookJpaEntity s " + | ||
| "WHERE s.userJpaEntity.userId = :userId AND s.bookJpaEntity.bookId = :bookId") | ||
| boolean existsByUserIdAndBookId(@Param("userId") Long userId, @Param("bookId") Long bookId); | ||
|
|
||
| @Modifying(clearAutomatically = true, flushAutomatically = true) | ||
| @Query("DELETE FROM SavedBookJpaEntity s WHERE s.userJpaEntity.userId = :userId AND s.bookJpaEntity.bookId = :bookId") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -156,7 +156,6 @@ public enum ErrorCode implements ResponseCode { | |
| TAG_NOT_FOUND(HttpStatus.NOT_FOUND, 160002, "존재하지 않는 TAG 입니다."), | ||
| INVALID_FEED_COMMAND(HttpStatus.BAD_REQUEST, 160003, "유효하지 않은 FEED 생성/수정 요청 입니다."), | ||
| FEED_ACCESS_FORBIDDEN(HttpStatus.FORBIDDEN, 160004, "피드 접근 권한이 없습니다."), | ||
| FEED_ALREADY_SAVED(HttpStatus.BAD_REQUEST, 160006, "사용자가 이미 저장한 피드입니다."), | ||
| FEED_NOT_SAVED_CANNOT_DELETE(HttpStatus.BAD_REQUEST, 160007, "사용자가 저장하지 않은 피드는 저장삭제 할 수 없습니다."), | ||
| FEED_CAN_NOT_SHOW_PRIVATE_ONE(HttpStatus.BAD_REQUEST, 160008, "비공개 피드는 피드 작성자 이외에는 조회할 수 없습니다."), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,22 @@ | ||
| package konkuk.thip.feed.adapter.out.persistence; | ||
|
|
||
| import konkuk.thip.common.entity.StatusType; | ||
| import konkuk.thip.common.util.Cursor; | ||
| import konkuk.thip.common.util.CursorBasedList; | ||
| import konkuk.thip.feed.adapter.out.mapper.FeedMapper; | ||
| import konkuk.thip.feed.adapter.out.persistence.repository.FeedJpaRepository; | ||
| import konkuk.thip.feed.adapter.out.persistence.repository.FeedTag.FeedTagJpaRepository; | ||
| import konkuk.thip.feed.adapter.out.persistence.repository.SavedFeedJpaRepository; | ||
| import konkuk.thip.feed.application.port.out.FeedQueryPort; | ||
| import konkuk.thip.feed.application.port.out.dto.TagCategoryQueryDto; | ||
| import konkuk.thip.feed.application.port.out.dto.FeedQueryDto; | ||
| import konkuk.thip.user.adapter.out.persistence.repository.UserJpaRepository; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.stereotype.Repository; | ||
|
|
||
| import java.time.LocalDateTime; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| @Repository | ||
| @RequiredArgsConstructor | ||
|
|
@@ -112,40 +100,13 @@ public int countPublicFeedsByUserId(Long userId) { | |
| } | ||
|
|
||
| @Override | ||
| public Set<Long> findSavedFeedIdsByUserIdAndFeedIds(Set<Long> feedIds, Long userId) { | ||
| return savedFeedJpaRepository.findSavedFeedIdsByUserIdAndFeedIds(userId, feedIds); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean existsSavedFeedByUserIdAndFeedId(Long userId, Long feedId) { | ||
| return savedFeedJpaRepository.existsByUserIdAndFeedId(userId, feedId); | ||
| } | ||
|
|
||
| @Override | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,4 +24,8 @@ public interface SavedFeedJpaRepository extends JpaRepository<SavedFeedJpaEntity | |
| @Modifying(clearAutomatically = true, flushAutomatically = true) | ||
| @Query("DELETE FROM SavedFeedJpaEntity sf WHERE sf.feedJpaEntity.postId = :feedId") | ||
| int deleteAllByFeedId(@Param("feedId") Long feedId); | ||
|
|
||
| @Query("SELECT CASE WHEN COUNT(s) > 0 THEN true ELSE false END FROM SavedFeedJpaEntity s " + | ||
| "WHERE s.userJpaEntity.userId = :userId AND s.feedJpaEntity.postId = :feedId") | ||
| boolean existsByUserIdAndFeedId(@Param("userId") Long userId, @Param("feedId") Long feedId); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,6 @@ | |
| import konkuk.thip.common.util.CursorBasedList; | ||
| import konkuk.thip.feed.application.port.out.dto.TagCategoryQueryDto; | ||
| import konkuk.thip.feed.application.port.out.dto.FeedQueryDto; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
@@ -36,11 +35,10 @@ public interface FeedQueryPort { | |
| /** | ||
| * 저장된 피드 조회 | ||
| */ | ||
|
|
||
| Set<Long> findSavedFeedIdsByUserIdAndFeedIds(Set<Long> feedIds, Long userId); | ||
|
|
||
| boolean existsSavedFeedByUserIdAndFeedId(Long userId, Long feedId); | ||
|
|
||
| /** | ||
| * 특정 책으로 작성된 피드 조회 | ||
|
|
@@ -50,4 +48,9 @@ public interface FeedQueryPort { | |
| CursorBasedList<FeedQueryDto> findFeedsByBookIsbnOrderByLatest(String isbn, Long userId, Cursor cursor); | ||
|
|
||
| List<Long> findLatestPublicFeedCreatorsIn(Set<Long> userIds, int size); | ||
|
|
||
| /** | ||
| * 모든 태그 조회 | ||
| */ | ||
| List<TagCategoryQueryDto> findAllTags(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,18 @@ | ||
| package konkuk.thip.feed.application.service; | ||
|
|
||
| import konkuk.thip.common.exception.BusinessException; | ||
| import konkuk.thip.feed.application.port.in.FeedSavedUseCase; | ||
| import konkuk.thip.feed.application.port.in.dto.FeedIsSavedCommand; | ||
| import konkuk.thip.feed.application.port.in.dto.FeedIsSavedResult; | ||
| import konkuk.thip.feed.application.port.out.FeedCommandPort; | ||
| import konkuk.thip.feed.application.port.out.FeedQueryPort; | ||
| import konkuk.thip.feed.domain.Feed; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.stereotype.Service; | ||
| import org.springframework.transaction.annotation.Transactional; | ||
|
|
||
| import static konkuk.thip.common.exception.code.ErrorCode.*; | ||
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class FeedSavedService implements FeedSavedUseCase { | ||
|
|
@@ -20,24 +22,31 @@ public class FeedSavedService implements FeedSavedUseCase { | |
|
|
||
| @Override | ||
| @Transactional | ||
| public FeedIsSavedResult changeSavedFeed(FeedIsSavedCommand command) { | ||
|
|
||
| // 1. 피드 검증 및 조회 | ||
| Feed feed = feedCommandPort.getByIdOrThrow(command.feedId()); | ||
|
|
||
| // 2. 유저가 해당 피드를 저장했는지 여부 조회 | ||
| boolean alreadySaved = feedQueryPort.existsSavedFeedByUserIdAndFeedId(command.userId(), feed.getId()); | ||
| validateSaveFeedAction(command.isSaved(), alreadySaved); | ||
|
Comment on lines
+30
to
+32
|
||
|
|
||
| if (command.isSaved()) { | ||
| feedCommandPort.saveSavedFeed(command.userId(), feed.getId()); | ||
| } else { | ||
| feedCommandPort.deleteSavedFeed(command.userId(), feed.getId()); | ||
| } | ||
|
|
||
| return FeedIsSavedResult.of(feed.getId(), command.isSaved()); | ||
| } | ||
|
Comment on lines
+25
to
+41
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chaincheck-then-act 경쟁 상태 가능성: 유니크 제약 및 예외 매핑으로 보강 권장 현재 플로우는
형태의 check-then-act 패턴입니다. 동시 요청이 들어오면, 존재 여부 확인 직후 상태가 바뀌는 경쟁 상태가 발생할 수 있습니다. 이를 안전하게 만들기 위해 다음을 권장합니다. 필수 보강(권장 구현):
예시 패치: @@
- if (command.isSaved()) {
- feedCommandPort.saveSavedFeed(command.userId(), feed.getId());
- } else {
- feedCommandPort.deleteSavedFeed(command.userId(), feed.getId());
- }
+ if (command.isSaved()) {
+ try {
+ feedCommandPort.saveSavedFeed(command.userId(), feed.getId());
+ } catch (org.springframework.dao.DataIntegrityViolationException e) {
+ // 동시성 등으로 인한 중복 저장 시도를 비즈니스 예외로 변환
+ throw new BusinessException(FEED_ALREADY_SAVED);
+ }
+ } else {
+ // 사전 검증으로 not-saved 삭제는 방지되나, 동시성으로 사라진 경우도 고려하여
+ // deleteSavedFeed 구현이 영향 행 수를 반환한다면 체크/로깅을 고려할 수 있습니다.
+ feedCommandPort.deleteSavedFeed(command.userId(), feed.getId());
+ }또한, SavedFeed 테이블에 유니크 인덱스가 없으면 위 보강만으로는 완전하지 않습니다. 아래 스크립트로 유니크 제약 및 예외 매핑 유무를 확인해 주세요. 필요 시 후속 PR에서 제약 추가/예외 매핑을 도와드릴 수 있습니다. 🏁 Script executed: #!/bin/bash
# SavedFeed 유니크 제약 및 저장/삭제 구현에서의 예외 매핑 여부 확인
echo "== SavedFeedJpaEntity 정의 위치 =="
rg -n "class\s+SavedFeedJpaEntity\b" -C2
echo
echo "== @Table(uniqueConstraints=...), unique=true 등 유니크 제약 여부 =="
rg -n "@Table\(" -C2
rg -n "uniqueConstraints" -C2
rg -n "unique\s*=\s*true" -C2
echo
echo "== saveSavedFeed/deleteSavedFeed 구현 및 예외 매핑 흔적 =="
rg -n "saveSavedFeed\s*\(" -C3
rg -n "deleteSavedFeed\s*\(" -C3
rg -n "DataIntegrityViolationException|DuplicateKeyException|FEED_ALREADY_SAVED|FEED_NOT_SAVED_CANNOT_DELETE" -C2Length of output: 21004 DB 유니크 제약 및 예외 처리 보강 필요 현재 SavedFeed 엔티티에는 (user_id, feed_id) 복합 유니크 제약이 없고, 저장 로직에서도 동시 중복 저장 시 발생하는 예외를 잡아 변환하는 처리가 빠져 있습니다. 경쟁 상태를 방지하고 최종 일관성을 보장하기 위해 아래와 같이 반영을 권장합니다.
위 보강 작업 후, FeedChangeSavedApiTest에서 중복 저장/삭제 시나리오가 여전히 올바르게 동작하는지 재검증해주세요. 🤖 Prompt for AI Agents |
||
|
|
||
| private void validateSaveFeedAction(boolean isSaveRequest, boolean alreadySaved) { | ||
| if (isSaveRequest && alreadySaved) { | ||
| // 이미 저장되어 있는 피드를 다시 저장하려는 경우 예외 처리 | ||
| throw new BusinessException(FEED_ALREADY_SAVED); | ||
| } else if (!isSaveRequest && !alreadySaved) { | ||
| // 저장되지 않은 피드를 삭제하려는 경우 예외 처리 | ||
| throw new BusinessException(FEED_NOT_SAVED_CANNOT_DELETE); | ||
| } | ||
|
Comment on lines
+43
to
+50
|
||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳굳 기존 컨테이너 강제로 내리면 개발서버가 좀 더 안정화될수도 있겠네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존에는 mysql redis까지 모두 내렸다가 다시 올렸는데 생각해보니 두 컨테이너는 굳이 내릴 필요가 없다고 판단해서 그냥 서버 컨테이너만 내렸다가 올리려고 합니다!