Conversation
- 등록한 hibernate filter 가 잘 동작하는지 확인하기 위해 테스트 코드 작성
- 누락된 nullable = false 추가 - jpa 상속 관계인 엔티티들은 single table 전략 이슈로 인해 nullable = true 유지
- status filter 를 적용하기 위한 트랜잭션을 서비스 메서드가 시작하도록 명시
- spring data jpa repository 가 제공하는 디폴트 findById 메서드는 내부적으로 바로 PK 기준으로 em.find() 로 동작하므로 filter 적용대상이 아님 - 따라서 소프트 딜리트 적용 대상 entity 를 단건조회할 시에는 custom 메서드를 정의하여 사용해야함
- soft delete 적용 대상인 entity 조회 시 custom 단건 조회 메서드 호출하도록 수정 - status 조건 코드 삭제
…book [feat] 책 삭제 스케줄러 도입
- soft delete 적용 대상인 entity 삭제 시 deleteAllInBatch 메서드 호출하도록 수정
[Feat] 회원 탈퇴 구현 및 투표 조회시 투표 득표수 보여주도록 수정
FCM 기반 푸쉬알림 기능 구현
…tion-on-off [Feat] 사용자 푸시알림 수신여부 조회
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 192 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Results457 tests 457 ✅ 46s ⏱️ Results for commit 8d32a36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
v.1.2.5 업데이트 내용
📸 스크린샷
💬 리뷰 요구사항
📌 PR 진행 시 이러한 점들을 참고해 주세요