[chore] github ci/cd 워크플로 설정#9
Merged
Merged
Conversation
seongjunnoh
reviewed
May 27, 2025
Comment on lines
+33
to
+37
| - name: 🧾 Create application.yml from secret | ||
| run: | | ||
| cd ${{env.RESOURCE_PATH}} | ||
| rm -f application.yml | ||
| echo "${{ secrets.APPLICATION_YML_DEV }}" > application.yml |
| build/ | ||
| !**/src/main/**/build/ | ||
| !**/src/test/**/build/ | ||
| *.yml |
Comment on lines
+60
to
+82
| --- | ||
|
|
||
| # dev DB | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: db-dev | ||
|
|
||
| datasource: | ||
| url: ${DEV_DB_URL} | ||
| username: ${DEV_DB_USER} | ||
| password: ${DEV_DB_PASSWORD} | ||
| driver-class-name: org.postgresql.Driver | ||
|
|
||
| jpa: | ||
| hibernate: | ||
| ddl-auto: update | ||
| show-sql: true | ||
| properties: | ||
| hibernate: | ||
| format_sql: true | ||
| dialect: org.hibernate.dialect.PostgreSQLDialect | ||
|
|
Collaborator
There was a problem hiding this comment.
p3 : application.yml 에서는 local, dev, prod를 나누지 말고 그냥 필요한 데이터의 템플릿 형식 1개만 보여주는게 어떤가요??
dev 서버인 경우, application-dev.yml 을 application.yml로 바꿔치기하는데 이러면 어차피 application.yml 에 명시된 dev 관련 값들은 무시되는데 굳이 dev용 값에 대한 명시를 application.yml 에 할 필요가 있나 싶습니다!
Contributor
Author
There was a problem hiding this comment.
넵 그러면 application.yml은 깃에서 삭제하고 로컬에서 관리하는 것으로 하겠습니다!
seongjunnoh
previously approved these changes
May 27, 2025
seongjunnoh
previously approved these changes
May 27, 2025
hd0rable
previously approved these changes
May 28, 2025
| docker build --build-arg PORT=${{env.APP_PORT}} -f Dockerfile -t ${{ secrets.DOCKER_USERNAME }}/${{ secrets.DOCKER_IMAGE }} . | ||
| docker push ${{ secrets.DOCKER_USERNAME }}/${{ secrets.DOCKER_IMAGE }} | ||
|
|
||
| # - name: 🪪 Configure AWS credentials |
Member
There was a problem hiding this comment.
이 주석은 후에 사용될것을 대비해서 주석처리 한것인가욧? 후에 ec2에 직접접속할 것을 대비해서 해놓으신건지 궁금합니닷
Contributor
Author
There was a problem hiding this comment.
후에 직접 접속할 수도 있을 것 같아서 주석처리해두었는데 현재로서는 제거하는게 좋을 것 같네요~!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
📸 스크린샷
💬 리뷰 요구사항
📌 PR 진행 시 이러한 점들을 참고해 주세요