Conversation
브랜치 히스토리 동기화: main -> develop
fix: 소셜로그인 로직 수정
|
Caution Review failedThe pull request is closed. Walkthrough소셜 로그인 토큰 처리 흐름을 대체/확장했습니다. OAuth 훅(useOAuthToken)을 제거하고, 경로에 따라 쿠키 설정 또는 임시 토큰 교환을 수행하는 useSocialLoginToken 훅을 추가했습니다. 이에 맞춰 Feed/Signup 페이지를 갱신했으며, /auth/set-cookie 및 /auth/exchange-temp-token API 클라이언트 래퍼와 인덱스 재노출을 추가했습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User/Browser
participant P as Page (Feed/Signup)
participant H as useSocialLoginToken
participant C as apiClient
participant S as Auth Service
U->>P: 페이지 로드
P->>H: 훅 초기화
H->>H: URL에서 loginTokenKey 추출
alt 경로 = /signup
H->>C: POST /auth/set-cookie (withCredentials)
else 기타 경로
H->>C: POST /auth/exchange-temp-token (withCredentials)
end
C->>S: 요청 전달
S-->>C: 응답(성공/실패)
C-->>H: 응답 반환
alt 성공
H->>U: URL의 loginTokenKey 파라미터 제거(replaceState)
else 실패
H->>P: 로그/필요시 navigate('/')
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (8)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이하동일
Summary by CodeRabbit
새 기능
개선/리팩터