Skip to content

Feat/comment hotfix#165

Merged
ljh130334 merged 7 commits into
developfrom
feat/comment-hotfix
Aug 19, 2025
Merged

Feat/comment hotfix#165
ljh130334 merged 7 commits into
developfrom
feat/comment-hotfix

Conversation

@ljh130334
Copy link
Copy Markdown
Member

@ljh130334 ljh130334 commented Aug 19, 2025

#๏ธโƒฃ ์—ฐ๊ด€๋œ ์ด์Šˆ

์ƒ๋žต

๐Ÿ“ ์ž‘์—… ๋‚ด์šฉ

๊ธฐ๋ก์žฅ์—์„œ ๋Œ“๊ธ€ ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹ค. ์‚ฌ์šฉ์ž๊ฐ€ ๊ธฐ๋ก์— ๋Œ€ํ•ด ๋Œ“๊ธ€์„ ์ž‘์„ฑํ•˜๊ณ  ๋‹ต๊ธ€์„ ๋‹ฌ ์ˆ˜ ์žˆ๋Š” ๋ฐ”ํ…€์‹œํŠธ UI๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ•ธ๏ธ ์ฃผ์š” ๊ตฌํ˜„ ์‚ฌํ•ญ

1. ๋Œ“๊ธ€ ๋ฐ”ํ…€์‹œํŠธ ์‹œ์Šคํ…œ ๊ตฌ์ถ•

  • useCommentBottomSheetStore๋ฅผ ํ†ตํ•œ ์ „์—ญ ์ƒํƒœ ๊ด€๋ฆฌ ๊ตฌํ˜„
  • GlobalCommentBottomSheet ์ปดํฌ๋„ŒํŠธ๋กœ ํ•˜๋‹จ์—์„œ ์Šฌ๋ผ์ด๋“œ์—…๋˜๋Š” ๋ฐ”ํ…€์‹œํŠธ UI ์ œ์ž‘
  • ๊ธฐ์กด BookSearchBottomSheet์™€ ๋™์ผํ•œ ์•„ํ‚คํ…์ฒ˜ ํŒจํ„ด ์ ์šฉ

2. ๊ธฐ๋ก์žฅ ๋Œ“๊ธ€ ๋ฒ„ํŠผ ์—ฐ๋™

  • RecordItem ์ปดํฌ๋„ŒํŠธ์˜ ๋Œ“๊ธ€ ๋ฒ„ํŠผ์— ํด๋ฆญ ํ•ธ๋“ค๋Ÿฌ ์ถ”๊ฐ€
  • ๋ฒ„ํŠผ ํด๋ฆญ ์‹œ ํ•ด๋‹น ๊ธฐ๋ก์˜ postId์™€ postType(RECORD/VOTE)์„ ์ „๋‹ฌํ•˜์—ฌ ๋ฐ”ํ…€์‹œํŠธ ์˜คํ”ˆ

3. ๋Œ“๊ธ€ ๊ธฐ๋Šฅ ์™„์ „ ๊ตฌํ˜„

  • ๋Œ“๊ธ€ ๋ชฉ๋ก ์กฐํšŒ (getComments API ์—ฐ๋™)
  • ๋Œ“๊ธ€ ์ž‘์„ฑ (postReply API ์—ฐ๋™)
  • ๋‹ต๊ธ€ ์ž‘์„ฑ ๋ฐ ์ทจ์†Œ ๊ธฐ๋Šฅ
  • ๊ธฐ์กด ReplyList, MessageInput ์ปดํฌ๋„ŒํŠธ ์žฌ์‚ฌ์šฉ์œผ๋กœ ์ผ๊ด€๋œ UX ์ œ๊ณต

4. UI/UX ๊ฐœ์„ 

  • ๋ฐ”ํ…€์‹œํŠธ ์• ๋‹ˆ๋ฉ”์ด์…˜ (์•„๋ž˜์—์„œ ์œ„๋กœ ์Šฌ๋ผ์ด๋“œ)
  • Dim ์˜์—ญ ํด๋ฆญ ์‹œ ๋ฐ”ํ…€์‹œํŠธ ๋‹ซ๊ธฐ
  • ๋กœ๋”ฉ ์ƒํƒœ ๋ฐ ์—๋Ÿฌ ์ฒ˜๋ฆฌ

5. ์„ฑ๋Šฅ ์ตœ์ ํ™”

  • ๋Œ“๊ธ€ ์ž…๋ ฅ ์ง€์—ฐ ํ˜„์ƒ ํ•ด๊ฒฐ (์ƒํƒœ ๋™๊ธฐํ™” ์ด์Šˆ ์ˆ˜์ •)
  • useCallback์„ ํ†ตํ•œ ๋ถˆํ•„์š”ํ•œ ๋ฆฌ๋ Œ๋”๋ง ๋ฐฉ์ง€
  • ๋ฐ”ํ…€์‹œํŠธ ๋‹ซํž ๋•Œ ์ƒํƒœ ์ดˆ๊ธฐํ™”๋กœ ๋ฉ”๋ชจ๋ฆฌ ํšจ์œจ์„ฑ ๊ฐœ์„ 

Summary by CodeRabbit

  • ์‹ ๊ธฐ๋Šฅ
    • ์ „์ฒด ํ™”๋ฉด์—์„œ ๋Œ“๊ธ€ ํ•˜๋‹จ ์‹œํŠธ๋ฅผ ๋„์ž…ํ•˜์—ฌ ๊ฒŒ์‹œ๋ฌผ์˜ ๋Œ“๊ธ€์„ ํ™•์ธํ•˜๊ณ  ์ž‘์„ฑํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
    • ๋Œ“๊ธ€/๋Œ€๋Œ“๊ธ€ ์ž‘์„ฑ ์ง€์› ๋ฐ ์ „์†ก ์ค‘/๋กœ๋”ฉ ์ƒํƒœ ํ‘œ์‹œ๋กœ ์‚ฌ์šฉ์„ฑ์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ์™ธ๋ถ€ ์˜์—ญ ํƒญ์œผ๋กœ ์‹œํŠธ๋ฅผ ๋‹ซ์„ ์ˆ˜ ์žˆ์œผ๋ฉฐ, ๋ฐ˜์‘ํ˜• ๋ ˆ์ด์•„์›ƒ๊ณผ ์Šค์™€์ดํ”„ํ˜• ์• ๋‹ˆ๋ฉ”์ด์…˜์„ ์ œ๊ณตํ•ฉ๋‹ˆ๋‹ค.
    • ๋ฉ”๋ชจ๋ฆฌ ํŽ˜์ด์ง€์— ์ „์—ญ ๋Œ“๊ธ€ ์‹œํŠธ๋ฅผ ํ†ตํ•ฉํ•˜์—ฌ ํ”ผ๋“œ/๊ธฐ๋ก/ํˆฌํ‘œ ์œ ํ˜• ๊ฒŒ์‹œ๋ฌผ์— ๊ณตํ†ต์œผ๋กœ ์‚ฌ์šฉ ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.
    • ์ž…๋ ฅ์ฐฝ ํ”Œ๋ ˆ์ด์Šคํ™€๋”๊ฐ€ ๋Œ€๋Œ“๊ธ€ ๋ชจ๋“œ์— ๋”ฐ๋ผ ์ž๋™์œผ๋กœ ๋ณ€๊ฒฝ๋ฉ๋‹ˆ๋‹ค.

  - useReplyActions ๋Œ€์‹  postReply API ์ง์ ‘ ์‚ฌ์šฉ
  - ์ƒํƒœ ๋™๊ธฐํ™” ์ง€์—ฐ์œผ๋กœ ์ธํ•œ ๋Œ“๊ธ€ ์ „์†ก ๋ฒ„๊ทธ ์ˆ˜์ •
  - ๋Œ“๊ธ€ ์ž‘์„ฑ ์‹œ ์ฆ‰์‹œ ์—…๋กœ๋“œ๋˜๋„๋ก ๊ฐœ์„ 
  - BookSearchBottomSheet ํŒจํ„ด์œผ๋กœ Memory ํŽ˜์ด์ง€์—์„œ๋งŒ ๋ Œ๋”๋ง
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 19, 2025 3:07am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 19, 2025

Walkthrough

์ „์—ญ ๋Œ“๊ธ€ ๋ฐ”ํ…€์‹œํŠธ๋ฅผ ๋„์ž…. Zustand ์Šคํ† ์–ด๋กœ ์—ด๋ฆผ/์ปจํ…์ŠคํŠธ ์ƒํƒœ๋ฅผ ๊ด€๋ฆฌํ•˜๊ณ , ํŽ˜์ด์ง€(Memory)์—์„œ ๊ธ€๋กœ๋ฒŒ ์ปดํฌ๋„ŒํŠธ๋ฅผ ๋งˆ์šดํŠธ. RecordItem ํด๋ฆญ์œผ๋กœ ์Šคํ† ์–ด๋ฅผ ํ†ตํ•ด ์‹œํŠธ๋ฅผ ์—ด๊ณ , ์‹œํŠธ ์ปดํฌ๋„ŒํŠธ๋Š” ์—ด๋ฆด ๋•Œ ๋Œ“๊ธ€์„ ๋กœ๋“œํ•˜๋ฉฐ ์ž…๋ ฅ/์ „์†ก/๋‹ต๊ธ€ ํ๋ฆ„๊ณผ ๋‹ซ๊ธฐ๋ฅผ ์ฒ˜๋ฆฌ. ์‹ ๊ทœ ์Šคํƒ€์ผ ๋ชจ๋“ˆ ํฌํ•จ.

Changes

Cohort / File(s) Change Summary
์ „์—ญ ๋ฐ”ํ…€์‹œํŠธ ์Šคํƒ€์ผ ์ถ”๊ฐ€
src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.styled.ts
Emotion ์Šคํƒ€์ผ ์ปดํฌ๋„ŒํŠธ 7์ข… ์ถ”๊ฐ€(Overlay, BottomSheet, Header, Title, Content, LoadingState, InputSection). isOpen prop์œผ๋กœ Overlay/BottomSheet ๊ฐ€์‹œ์„ฑยท์• ๋‹ˆ๋ฉ”์ด์…˜ ์ œ์–ด. ํ…Œ๋งˆ ์ƒ‰์ƒ/ํƒ€์ดํฌ ์‚ฌ์šฉ.
์ „์—ญ ๋ฐ”ํ…€์‹œํŠธ ์ปดํฌ๋„ŒํŠธ ์ถ”๊ฐ€
src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.tsx
GlobalCommentBottomSheet ์ปดํฌ๋„ŒํŠธ ์‹ ์„ค. ์—ด๋ฆด ๋•Œ getComments ๋กœ๋“œ, postReply๋กœ ๋Œ“๊ธ€/๋‹ต๊ธ€ ์ „์†ก, isLoading/isSending ์ƒํƒœ ๊ด€๋ฆฌ, ์™ธ๋ถ€ ํด๋ฆญ์œผ๋กœ close. ReplyList/MessageInput ์—ฐ๋™. ๋‹ซํž ๋•Œ ์ž…๋ ฅ/๋ฆฌ์ŠคํŠธ/๋‹ต๊ธ€ ์ƒํƒœ ์ดˆ๊ธฐํ™”.
์Šคํ† ์–ด ๋„์ž…(Zustand)
src/stores/useCommentBottomSheetStore.ts
isOpen, postId, postType('RECORD'
ํŽ˜์ด์ง€์— ์ „์—ญ ๋ฐ”ํ…€์‹œํŠธ ๋งˆ์šดํŠธ
src/pages/memory/Memory.tsx
GlobalCommentBottomSheet๋ฅผ ํŽ˜์ด์ง€์— ๊ณ ์ • ๋ Œ๋”๋ง.
๋ ˆ์ฝ”๋“œ ์•„์ดํ…œ์—์„œ ํ˜ธ์ถœ ์—ฐ๊ฒฐ
src/components/memory/RecordItem/RecordItem.tsx
๋Œ“๊ธ€ ๋ฒ„ํŠผ ํด๋ฆญ ์‹œ openCommentBottomSheet(postId, postType) ํ˜ธ์ถœ ์ถ”๊ฐ€. postType ๋งคํ•‘(VOTE/RECORD). ๋™์ผ ์Šค์ฝ”ํ”„ ๋‚ด handleCommentClick ์ค‘๋ณต ์„ ์–ธ(์žฌ์ •์˜ ์˜ค๋ฅ˜ ์œ ๋ฐœ).

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant RI as RecordItem
  participant Store as useCommentBottomSheetStore
  participant Page as Memory Page
  participant Sheet as GlobalCommentBottomSheet
  participant API as API (getComments/postReply)

  U->>RI: ๋Œ“๊ธ€ ๋ฒ„ํŠผ ํด๋ฆญ
  RI->>Store: openCommentBottomSheet(postId, postType)
  Store-->>Page: isOpen=true ์ƒํƒœ ๋ณ€๊ฒฝ
  Page-->>Sheet: ์ปดํฌ๋„ŒํŠธ ๋ Œ๋”๋ง/๊ฐฑ์‹ 
  Sheet->>API: getComments(postId, postType)
  API-->>Sheet: ๋Œ“๊ธ€ ๋ชฉ๋ก
  U->>Sheet: ์ž…๋ ฅ ํ›„ ์ „์†ก
  Sheet->>API: postReply(payload)
  API-->>Sheet: ์„ฑ๊ณต ์‘๋‹ต
  Sheet->>API: getComments ์žฌ์กฐํšŒ
  U->>Sheet: ๋ฐ”๊นฅ ์˜์—ญ ํด๋ฆญ(๋‹ซ๊ธฐ)
  Sheet->>Store: closeCommentBottomSheet()
Loading

Estimated code review effort

๐ŸŽฏ 4 (Complex) | โฑ๏ธ ~60 minutes

Possibly related PRs

Suggested labels

โœจ Feature, ๐ŸŽจ Html&css

Poem

ํ† ๋ผ๋Š” ํƒโ€” ํˆญโ€” ๋Œ“๊ธ€์„ ํ†ก

์‹œํŠธ๋Š” ์Šฅโ€” ์Љโ€” ์•„๋ž˜์„œ ์™

๋ฒˆ์ฉ ์—ด๊ณ , ์‚ด์ง ๋‹ซ๊ณ , ๋ง์ด ํ๋ฅด๊ณ โ€”

๊ธฐ์–ต์˜ ๊ธฐ๋ก์— ๋‹ต๊ธ€์ด ํ”ผ๊ณ  ๐ŸŒฑ

๋ฐคํ•˜๋Š˜ ๊ฐ™๋˜ ์˜ค๋ฒ„๋ ˆ์ด์— ๋ณ„์ฒ˜๋Ÿผ ๋ฐ˜์ง! โœจ

Tip

๐Ÿ”Œ Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

โœจ Finishing Touches
  • ๐Ÿ“ Generate Docstrings
๐Ÿงช Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/comment-hotfix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share
๐Ÿชง Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

๐Ÿงน Nitpick comments (6)
src/stores/useCommentBottomSheetStore.ts (1)

3-12: postType ๋ฆฌํ„ฐ๋Ÿด ํƒ€์ž… ์žฌ์‚ฌ์šฉ์„ ์œ„ํ•œ ๋ณ„๋„ ํƒ€์ž… ๋„์ž… ์ œ์•ˆ

'RECORD' | 'VOTE' ์œ ๋‹ˆ์˜จ์„ ์—ฌ๋Ÿฌ ๊ตฐ๋ฐ์—์„œ ๋ฐ˜๋ณต ์‚ฌ์šฉํ•˜๋ฏ€๋กœ, ํ•œ ๊ณณ์—์„œ ์ •์˜ํ•ด ์žฌ์‚ฌ์šฉํ•˜๋ฉด ์œ ์ง€๋ณด์ˆ˜์„ฑ์ด ์ข‹์•„์ง‘๋‹ˆ๋‹ค.

์•„๋ž˜์ฒ˜๋Ÿผ ํƒ€์ž…์„ ์ •์˜ํ•ด ์žฌ์‚ฌ์šฉํ•ด ์ฃผ์„ธ์š”.

 interface CommentBottomSheetState {
   isOpen: boolean;
   postId: number | null;
-  postType: 'RECORD' | 'VOTE' | null;
+  postType: CommentPostType | null;
 }
 
 interface CommentBottomSheetActions {
-  openCommentBottomSheet: (postId: number, postType: 'RECORD' | 'VOTE') => void;
+  openCommentBottomSheet: (postId: number, postType: CommentPostType) => void;
   closeCommentBottomSheet: () => void;
 }
 
+export type CommentPostType = 'RECORD' | 'VOTE';

Also applies to: 21-22

src/components/memory/RecordItem/RecordItem.tsx (2)

58-59: Zustand ์…€๋ ‰ํ„ฐ๋กœ ๋ถˆํ•„์š”ํ•œ ๋ฆฌ๋ Œ๋” ์ค„์ด๊ธฐ

ํ˜„์žฌ useCommentBottomSheetStore()๋ฅผ ์ „์ฒด ์ƒํƒœ๋กœ ๊ตฌ๋…ํ•˜๊ณ  ์žˆ์–ด ๋ฐ”ํ…€์‹œํŠธ ์ƒํƒœ ๋ณ€๊ฒฝ ์‹œ ๋ชจ๋“  RecordItem์ด ๋ฆฌ๋ Œ๋”๋  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ์•ก์…˜๋งŒ ์„ ํƒ ๊ตฌ๋…ํ•˜๋ฉด ๋ฆฌ์ŠคํŠธ ์„ฑ๋Šฅ์ด ๊ฐœ์„ ๋ฉ๋‹ˆ๋‹ค.

-  const { openCommentBottomSheet } = useCommentBottomSheetStore();
+  const openCommentBottomSheet = useCommentBottomSheetStore(s => s.openCommentBottomSheet);

261-265: parseInt์— ๊ธฐ์ˆ˜(radix) ๋ช…์‹œ (๊ฐ€๋…์„ฑ/์•ˆ์ „์„ฑ ํ–ฅ์ƒ)

ํ˜„ํ–‰ ์ŠคํŽ™์ƒ ๊ธฐ๋ณธ 10์ง„์œผ๋กœ ํŒŒ์‹ฑ๋˜์ง€๋งŒ, ์˜๋„๋ฅผ ๋ช…ํ™•ํžˆ ํ•˜๊ธฐ ์œ„ํ•ด radix๋ฅผ ๋ช…์‹œํ•˜๋Š” ๊ฒƒ์„ ๊ถŒ์žฅํ•ฉ๋‹ˆ๋‹ค.

-  openCommentBottomSheet(parseInt(id), type === 'poll' ? 'VOTE' : 'RECORD');
+  openCommentBottomSheet(parseInt(id, 10), type === 'poll' ? 'VOTE' : 'RECORD');
src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.tsx (1)

61-62: ๋ถˆํ•„์š”ํ•œ ํƒ€์ž… ๋‹จ์–ธ ์ œ๊ฑฐ ์ œ์•ˆ

postType์€ ์ด๋ฏธ 'RECORD' | 'VOTE'๋กœ ์ถฉ๋ถ„ํžˆ ์ข์€ ํƒ€์ž…์ด๋ฏ€๋กœ, ์ƒ์œ„ ์œ ๋‹ˆ์˜จ('FEED' | 'RECORD' | 'VOTE')์œผ๋กœ์˜ ๋‹จ์–ธ์ด ํ•„์š” ์—†์Šต๋‹ˆ๋‹ค. ๋‹จ์–ธ์„ ์ค„์ด๋ฉด ํƒ€์ž… ์‹ ๋ขฐ๋„๊ฐ€ ์˜ฌ๋ผ๊ฐ‘๋‹ˆ๋‹ค.

-        postType: postType as 'FEED' | 'RECORD' | 'VOTE'
+        postType
src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.styled.ts (2)

20-33: min-width(360px)๋กœ ์ธํ•œ ์†Œํ˜• ๋””๋ฐ”์ด์Šค overflow ๊ฐ€๋Šฅ์„ฑ

ํญ 320px ๊ธฐ๊ธฐ(์˜ˆ: iPhone SE)์—์„œ ๊ฐ€๋กœ ์Šคํฌ๋กค์ด ๋ฐœ์ƒํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ๋ชจ๋ฐ”์ผ ๋Œ€์‘์„ ์œ„ํ•ด min-width๋ฅผ ์ œ๊ฑฐํ•˜๊ฑฐ๋‚˜ ๋ฏธ๋””์–ด์ฟผ๋ฆฌ๋กœ ์กฐ๊ฑด๋ถ€ ์ ์šฉ์„ ๊ถŒ์žฅํ•ฉ๋‹ˆ๋‹ค.

 export const BottomSheet = styled.div<{ isOpen: boolean }>`
   width: 100%;
   max-width: 540px;
-  min-width: 360px;
   background: ${colors.darkgrey.main};
   border-radius: 20px 20px 0 0;
   display: flex;
   flex-direction: column;
   max-height: 80vh;
   min-height: 50vh;
   transform: translateY(${props => (props.isOpen ? '0' : '100%')});
   transition: transform 0.3s ease;
   overflow: hidden;
 `;

15-17: transition ์†์„ฑ ์ผ์น˜ํ™” (๋ฏธ์„ธ ๊ฐœ์„ )

background ๊ฐ’์„ ๋ณ€๊ฒฝํ•˜๊ณ  ์žˆ์œผ๋ฏ€๋กœ transition: background๋กœ ๋งž์ถ”๋ฉด ์˜๋„๊ฐ€ ๋ถ„๋ช…ํ•ด์ง‘๋‹ˆ๋‹ค. opacity๋„ ํ•จ๊ป˜ ํŠธ๋žœ์ง€์…˜ํ•˜๋ฉด ๋” ์ž์—ฐ์Šค๋Ÿฝ์Šต๋‹ˆ๋‹ค.

-  transition: background-color 0.3s ease;
+  transition: background 0.3s ease, opacity 0.3s ease;
๐Ÿ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

๐Ÿ’ก Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 62c2187 and c51a04d.

๐Ÿ“’ Files selected for processing (5)
  • src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.styled.ts (1 hunks)
  • src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.tsx (1 hunks)
  • src/components/memory/RecordItem/RecordItem.tsx (5 hunks)
  • src/pages/memory/Memory.tsx (2 hunks)
  • src/stores/useCommentBottomSheetStore.ts (1 hunks)
๐Ÿงฐ Additional context used
๐Ÿงฌ Code Graph Analysis (3)
src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.styled.ts (1)
src/styles/global/global.ts (2)
  • colors (4-53)
  • typography (56-77)
src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.tsx (7)
src/stores/useCommentBottomSheetStore.ts (1)
  • useCommentBottomSheetStore (14-26)
src/api/comments/getComments.ts (2)
  • CommentData (3-16)
  • getComments (50-68)
src/hooks/useReplyActions.ts (1)
  • useReplyActions (10-54)
src/stores/useReplyStore.ts (1)
  • useReplyStore (15-28)
src/api/comments/postReply.ts (1)
  • postReply (19-22)
src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.styled.ts (7)
  • Overlay (4-18)
  • BottomSheet (20-33)
  • Header (35-39)
  • Title (41-47)
  • Content (49-53)
  • LoadingState (55-63)
  • InputSection (65-70)
src/components/today-words/MessageInput.styled.ts (1)
  • MessageInput (62-90)
src/components/memory/RecordItem/RecordItem.tsx (2)
src/stores/useCommentBottomSheetStore.ts (1)
  • useCommentBottomSheetStore (14-26)
src/components/memory/RecordItem/RecordItem.styled.ts (1)
  • ActionButton (60-79)
๐Ÿ”‡ Additional comments (4)
src/stores/useCommentBottomSheetStore.ts (1)

14-26: ์ „์—ญ ๋ฐ”ํ…€์‹œํŠธ ์ƒํƒœ/์•ก์…˜ ์„ค๊ณ„ ๊น”๋” โ€” LGTM

์ดˆ๊ธฐ๊ฐ’/๋ฆฌ์…‹ ์ฒ˜๋ฆฌ์™€ open/close ์•ก์…˜ ์ธํ„ฐํŽ˜์ด์Šค๊ฐ€ ๋ช…ํ™•ํ•ฉ๋‹ˆ๋‹ค. ๋‹ค๋ฅธ ์ปดํฌ๋„ŒํŠธ๋“ค์ด ์˜์กดํ•˜๊ธฐ ์ข‹๊ฒŒ ์ž˜ ๋ถ„๋ฆฌ๋˜์–ด ์žˆ์–ด์š”.

src/pages/memory/Memory.tsx (1)

8-8: GlobalCommentBottomSheet ํŽ˜์ด์ง€ ๋งˆ์šดํŠธ ์ถ”๊ฐ€ โ€” LGTM

๊ณ ์ • ์˜ค๋ฒ„๋ ˆ์ด(ํฌ์ง€์…˜ fixed) ํŠน์„ฑ์ƒ ํŽ˜์ด์ง€ ์ตœํ•˜๋‹จ์— ๋งˆ์šดํŠธํ•ด๋„ ์ •์ƒ ๋™์ž‘ํ•ฉ๋‹ˆ๋‹ค. Memory ํŽ˜์ด์ง€ ๋ฒ”์œ„์—์„œ๋งŒ ์‚ฌ์šฉํ•˜๋ ค๋Š” ์˜๋„์—๋„ ๋ถ€ํ•ฉํ•ฉ๋‹ˆ๋‹ค.

Also applies to: 299-301

src/components/memory/RecordItem/RecordItem.tsx (1)

379-382: ๋Œ“๊ธ€ ๋ฒ„ํŠผ โ†’ ๋ฐ”ํ…€์‹œํŠธ ์—ด๊ธฐ ์—ฐ๋™ โ€” LGTM

๋ฒ„๋ธ”๋ง ๋ฐฉ์ง€์™€ ์ „์—ญ ์‹œํŠธ ์˜คํ”ˆ ํ๋ฆ„์ด ์ผ๊ด€๋˜๊ฒŒ ์ž˜ ์—ฐ๊ฒฐ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.tsx (1)

92-97: ์—ด๋ฆด ๋•Œ ๋กœ๋“œ/๋‹ซํž ๋•Œ ๋ฆฌ์…‹ ํ”Œ๋กœ์šฐ ๋ช…ํ™• โ€” LGTM

  • ์‹œํŠธ ์˜คํ”ˆ ์‹œ ๋ชฉ๋ก ๋กœ๋“œ
  • ์‹œํŠธ ๋‹ซํž˜ ์‹œ ์ž…๋ ฅ/๋‹ต๊ธ€/๋ชฉ๋ก ๋ฆฌ์…‹

์ƒํƒœ ์ˆ˜๋ช… ์ฃผ๊ธฐ๊ฐ€ ๋ช…ํ™•ํ•ด UX ๋ฐ ๋ฉ”๋ชจ๋ฆฌ ํšจ์œจ ์ธก๋ฉด์—์„œ ์ข‹์Šต๋‹ˆ๋‹ค.

Also applies to: 98-105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant