merge: develop -> main

[ho0010]

merge: develop -> main

Summary by CodeRabbit

• 신기능/개선

  • 내 그룹 선택 모달에 무한 스크롤(자동 로드/페이지네이션) 도입 및 초기/탭 전환 시 안정적인 재로딩.
  • 추천 그룹 영역을 데이터가 있을 때만 표시하여 깔끔한 화면 제공.
  • 그룹 카드에서 공개/비공개 상태에 따른 잠금 표시 로직 반영.

• 스타일

  • 디자인 토큰 적용으로 타이포·컬러 일원화(여러 그룹/피드 컴포넌트).
  • 제목/헤더/책 정보 영역의 줄임표 처리 및 레이아웃 개선(오버플로 방지).
  • 버튼/섹션 크기 조정, 고정 너비 제거, 스크롤 영역 및 하단 로딩 스피너 UI 개선.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
thip	Ready	Preview	Comment	Aug 20, 2025 5:42pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Room 인터페이스에서 type:string을 isPublic:boolean으로 교체. 그룹 관련 타입과 카드가 isPublic을 수용하도록 확장. MyGroupModal에 무한 스크롤(페이지네이션, nextCursor/isLast, 스크롤 트리거, 초기 로드/탭 전환 재로딩) 추가. 다수 컴포넌트에서 디자인 토큰 적용 및 스타일/레이아웃 조정. 추천 섹션 조건부 렌더링 추가.

Changes

Cohort / File(s)	Summary
API: Room 스키마 변경 src/api/rooms/getMyRooms.ts	Room.type:string 제거, Room.isPublic:boolean 추가. 반환 객체 형태 변경.
Group: isPublic 전파 src/components/group/GroupCard.tsx, src/components/group/MyGroupBox.tsx	GroupCard Prop에 isPublic? 추가, 잠금 표시 조건을 group.isPublic === false로 변경. MyGroupBox의 Group 인터페이스에 isPublic? 필드 추가.
MyGroupModal: 무한 스크롤·매핑 src/components/group/MyGroupModal.tsx	nextCursor/isLast 기반 페이지네이션, 스크롤 감지 로딩, 초기/탭 전환 재로딩, 자동 채움(tryFill), 에러/빈 상태/로딩 표시. Room→Group 변환 시 isPublic 매핑.
디자인 토큰 적용 src/components/feed/BookInfoCard.tsx, src/components/group/MyGroupCard.tsx, src/components/group/RecruitingGroupBox.tsx	색상/타이포 CSS 변수 제거, colors/typography 토큰으로 교체. 기능 로직 변화 없음.
레이아웃·스타일 조정 src/components/common/Filter.tsx, src/components/search/MostSearchedBooks.tsx, src/pages/searchBook/SearchBook.styled.ts	Filter 고정 폭 제거. MostSearchedBooks 타이틀 플렉스/폭 제어 개선(ellipsis). 검색 페이지 버튼/섹션 크기 및 패딩 조정.
GroupDetail UI 변경 src/pages/groupDetail/GroupDetail.styled.ts, src/pages/groupDetail/GroupDetail.tsx	BookHeader 레이아웃 수정(h3 ellipsis, img 고정). 추천 섹션을 recommendRooms.length > 0일 때만 렌더링.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant M as MyGroupModal
  participant API as getMyRooms API

  U->>M: 모달 열기
  activate M
  M->>API: 첫 페이지 요청 (cursor: null | 초기값)
  API-->>M: rooms[], nextCursor, isLast
  M->>M: rooms 상태 설정, nextCursor/isLast 업데이트
  M->>M: tryFill()로 컨테이너 높이 채우기 시도 (반복 로드)
  deactivate M

  U->>M: 스크롤 하단 근접
  alt not loading AND !isLast
    M->>API: 다음 페이지 요청 (cursor: nextCursor)
    API-->>M: rooms[], nextCursor, isLast
    M->>M: 기존 rooms에 추가, nextCursor/isLast 갱신
  else isLast or loading
    M->>U: 더 불러올 데이터 없음 또는 로딩 중 표시
  end

  note over M: Room.isPublic → Group.isPublic 변환 후 GroupCard에 전달

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45–60 minutes

Possibly related PRs

• feat: Rooms 도메인 API 연동 #117: getMyRooms.ts의 Room 인터페이스를 다룬 변경으로, 이번 PR의 Room 스키마 수정과 직접적으로 연관.
• main merge #174: room 데이터에 isPublic을 도입/활용하는 변경으로, 본 PR의 isPublic 전파와 매핑 로직과 접점이 큼.
• feat: GroupSearch 로직 추가 적용, click 이벤트 적용 #159: GroupCard와 MyGroupModal의 룸→그룹 변환·네비게이션을 다뤄, 이번 Modal 확장 및 isPublic 매핑과 코드 레벨로 연관.

Suggested labels

📬 API, 🎨 Html&css

Suggested reviewers

• heeeeyong
• ljh130334

Poem

(\_/) 토큰 반짝, 스크롤 살짝—
(•ㅅ•) 방의 비밀은 isPublic 한 줄!
/︶\ 무한 스크롤 척척, 루프는 멈춤표로—
★ 카드와 헤더는 말끔히 정렬되어,
작은 당근 하나로 릴리즈 축하해! 🥕

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between eef4339 and 4984ff8.

⛔ Files ignored due to path filters (1)

• src/assets/common/filledSaveIcon.svg is excluded by !**/*.svg

📒 Files selected for processing (12)

• src/api/rooms/getMyRooms.ts (1 hunks)
• src/components/common/Filter.tsx (0 hunks)
• src/components/feed/BookInfoCard.tsx (3 hunks)
• src/components/group/GroupCard.tsx (2 hunks)
• src/components/group/MyGroupBox.tsx (1 hunks)
• src/components/group/MyGroupCard.tsx (3 hunks)
• src/components/group/MyGroupModal.tsx (8 hunks)
• src/components/group/RecruitingGroupBox.tsx (2 hunks)
• src/components/search/MostSearchedBooks.tsx (1 hunks)
• src/pages/groupDetail/GroupDetail.styled.ts (1 hunks)
• src/pages/groupDetail/GroupDetail.tsx (1 hunks)
• src/pages/searchBook/SearchBook.styled.ts (5 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.