-
Notifications
You must be signed in to change notification settings - Fork 0
main 배포 #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main 배포 #194
Changes from all commits
25a1d82
bad0d1f
4859ad9
c243dfe
c9ba2a9
1151c79
d825705
ac65401
970cc3b
5db1226
55ffb9f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,13 +10,13 @@ export const RecordSection = styled.section` | |||||||||||||||||||||||||||||||||||
| margin: 20px 20px 0 20px; | ||||||||||||||||||||||||||||||||||||
| padding: 16px 12px; | ||||||||||||||||||||||||||||||||||||
| border-radius: 12px; | ||||||||||||||||||||||||||||||||||||
| cursor: pointer; | ||||||||||||||||||||||||||||||||||||
| `; | ||||||||||||||||||||||||||||||||||||
|
Comment on lines
+13
to
14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 섹션 전체 클릭 전환 OK — 포커스 가시성 추가 제안
export const RecordSection = styled.section`
display: flex;
flex-direction: column;
width: calc(100% - 40px);
gap: 12px;
background: ${colors.darkgrey.dark};
margin: 20px 20px 0 20px;
padding: 16px 12px;
border-radius: 12px;
- cursor: pointer;
+ cursor: pointer;
+ &:focus-visible {
+ outline: 2px solid ${colors.purple.main};
+ outline-offset: 2px;
+ }
`;📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| export const RecordSectionHeader = styled.div` | ||||||||||||||||||||||||||||||||||||
| display: flex; | ||||||||||||||||||||||||||||||||||||
| justify-content: space-between; | ||||||||||||||||||||||||||||||||||||
| align-items: center; | ||||||||||||||||||||||||||||||||||||
| cursor: pointer; | ||||||||||||||||||||||||||||||||||||
| `; | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| export const RecordSectionTitle = styled.h3` | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,8 +20,8 @@ interface RecordSectionProps { | |
|
|
||
| const RecordSection = ({ currentPage, progress, onClick }: RecordSectionProps) => { | ||
| return ( | ||
| <StyledRecordSection> | ||
| <RecordSectionHeader onClick={onClick}> | ||
| <StyledRecordSection onClick={onClick}> | ||
| <RecordSectionHeader> | ||
|
Comment on lines
+23
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 컨테이너 onClick 이동은 타당 — 키보드 조작 가능하도록 역할/핸들러 추가 필요 접근성 준수를 위해 - <StyledRecordSection onClick={onClick}>
- <RecordSectionHeader>
+ <StyledRecordSection
+ role="button"
+ tabIndex={0}
+ onClick={onClick}
+ onKeyDown={handleKeyDown}
+ aria-label="기록장 이동"
+ >
+ <RecordSectionHeader>컴포넌트 내부에 핸들러 추가: // return 위에 추가
const handleKeyDown = (e: React.KeyboardEvent) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
onClick();
}
};🤖 Prompt for AI Agents |
||
| <RecordSectionTitle>기록장</RecordSectionTitle> | ||
| <RecordSectionChevron src={rightChevron} alt="기록장 이동 버튼" /> | ||
| </RecordSectionHeader> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비-버튼 요소 클릭: 키보드 접근성과 스크린 리더 지원 추가 필요
section클릭으로 바뀌면서 탭 포커스/Enter/Space 조작이 불가합니다.role="button",tabIndex,onKeyDown을 추가해 주세요.컴포넌트 내부에 핸들러를 추가하세요(타입 임포트가 번거로우면 any 생략 가능).
필요 시 타입 전용 임포트:
🤖 Prompt for AI Agents