Skip to content

fix: 모집중인 모임방 제목 넘침 수정#203

Merged
heeeeyong merged 2 commits into
developfrom
chore/minor-updates
Aug 21, 2025
Merged

fix: 모집중인 모임방 제목 넘침 수정#203
heeeeyong merged 2 commits into
developfrom
chore/minor-updates

Conversation

@heeeeyong
Copy link
Copy Markdown
Collaborator

@heeeeyong heeeeyong commented Aug 21, 2025

이하동일

Summary by CodeRabbit

  • 스타일

    • 그룹 카드 레이아웃을 조정해 제목 영역이 부모 폭을 넘치지 않도록 하고, 한 줄 말줄임(…)이 안정적으로 적용되도록 개선했습니다.
    • 긴 그룹명도 카드 폭에 맞춰 자연스럽게 잘림 처리되어 목록 가독성이 향상되었습니다.
  • 버그 수정

    • 피드 상세에서 댓글 새로고침 후 화면의 댓글 수가 실제 개수와 불일치하던 문제를 수정했습니다.
    • 이제 새로고침 시 댓글 수가 즉시 정확히 반영되어 지연·오표시가 발생하지 않습니다.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

이 PR은 GroupCard의 flex 레이아웃에서 텍스트 잘림(ellipsis)이 정상 동작하도록 CSS를 조정하고, Feed 상세 페이지에서 댓글 새로고침 후 상태의 commentCount를 실제 댓글 수로 동기화하며 관련 콜백 의존성을 갱신합니다.

Changes

Cohort / File(s) Summary
GroupCard 레이아웃/ellipsis 처리
src/components/group/GroupCard.tsx
Infomin-width: 0 추가, Titlewidth: 100% 추가로 flex 내 오버플로 방지 및 줄임표 적용 가능하게 수정
Feed 댓글 수 동기화
src/pages/feed/FeedDetailPage.tsx
reloadComments 이후 가져온 댓글 길이로 feedData.commentCount 업데이트(널 가드, 함수형 업데이트). reloadComments의 의존성 배열을 [feedId]에서 [feedId, feedData]로 확장

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant FDP as FeedDetailPage
  participant API as CommentsAPI
  participant ST as State

  U->>FDP: reloadComments() 트리거
  FDP->>API: fetchComments(feedId)
  API-->>FDP: comments[]
  FDP->>ST: setComments(comments)
  alt feedData != null
    FDP->>ST: setFeedData({...prev, commentCount: comments.length})
  else
    Note right of FDP: feedData가 없으면 commentCount 업데이트 생략
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

🎨 Html&css, 🐞 BugFix

Poem

깡총-깡총, 카드에 폭 줄였지요
제목은 폭-가득, 말줄임표로 요.
댓글 톡톡, 세면 세는 만큼만!
카운트 맞춰 딱—숫자도 말끔한.
(•̀ᴗ•́)و ̑̑ 코드엔 깃털, 버그는 훅—날아가네!

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0a7788e and 57b4c91.

📒 Files selected for processing (2)
  • src/components/group/GroupCard.tsx (2 hunks)
  • src/pages/feed/FeedDetailPage.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/minor-updates

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 21, 2025 8:09am

@heeeeyong heeeeyong changed the title fix: 모집중인 모임방 제목 넘치는거 수정 fix: 모집중인 모임방 제목 넘침 수정 Aug 21, 2025
@heeeeyong heeeeyong merged commit c70e9e8 into develop Aug 21, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant