Skip to content

Prevent NullPointerException by checking whether Knowledge Interaction ID is known by the receiver #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sophietje merged 2 commits into from
Feb 22, 2024
Merged

Prevent NullPointerException by checking whether Knowledge Interaction ID is known by the receiver #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b71924e
Check whether knowledge interaction id is unknown (i.e. null) in proc…
Sophietje Feb 22, 2024
070f6e7
Possibly fix the build bug.
bnouwt Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions smart-connector-rest-dist/src/test/java/eu/knowledge/engine/rest/RestServerHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ public void run() {

public void cleanUp() {
thread.interrupt();
try {
thread.join();
} catch (InterruptedException e) {
LOG.info("Failed to join thread.");
}
}

private static boolean portAvailable(int port) {
Expand Down
22 changes: 21 additions & 1 deletion ...ector/src/main/java/eu/knowledge/engine/smartconnector/impl/InteractionProcessorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import org.apache.jena.vocabulary.RDF;
import org.slf4j.Logger;

import eu.knowledge.engine.reasoner.BaseRule;
import eu.knowledge.engine.reasoner.Rule;
import eu.knowledge.engine.smartconnector.api.AnswerExchangeInfo;
import eu.knowledge.engine.smartconnector.api.AnswerKnowledgeInteraction;
Expand Down Expand Up @@ -203,6 +202,16 @@ public CompletableFuture<AnswerMessage> processAskFromMessageRouter(AskMessage a
KnowledgeInteractionInfo knowledgeInteractionById = this.myKnowledgeBaseStore
.getKnowledgeInteractionById(answerKnowledgeInteractionId);

if (knowledgeInteractionById == null) {
AnswerMessage m = new AnswerMessage(anAskMsg.getToKnowledgeBase(), anAskMsg.getToKnowledgeInteraction(),
anAskMsg.getFromKnowledgeBase(), anAskMsg.getFromKnowledgeInteraction(), anAskMsg.getMessageId(),
"Received AskMessage wth unknown ToKnowledgeInteractionId");
LOG.debug("Received AskMessage with unknown ToKnowledgeInteractionId: "+anAskMsg.getToKnowledgeInteraction().toString());
CompletableFuture<AnswerMessage> f = new CompletableFuture<>();
f.complete(m);
return f;
}

AnswerKnowledgeInteraction answerKnowledgeInteraction;
answerKnowledgeInteraction = (AnswerKnowledgeInteraction) knowledgeInteractionById.getKnowledgeInteraction();

Expand Down Expand Up @@ -305,6 +314,17 @@ public CompletableFuture<ReactMessage> processPostFromMessageRouter(PostMessage
URI reactKnowledgeInteractionId = aPostMsg.getToKnowledgeInteraction();
KnowledgeInteractionInfo knowledgeInteractionById = this.myKnowledgeBaseStore
.getKnowledgeInteractionById(reactKnowledgeInteractionId);

if (knowledgeInteractionById == null) {
ReactMessage m = new ReactMessage(aPostMsg.getToKnowledgeBase(), aPostMsg.getToKnowledgeInteraction(),
aPostMsg.getFromKnowledgeBase(), aPostMsg.getFromKnowledgeInteraction(), aPostMsg.getMessageId(),
"Received PostMessage with unknown ToKnowledgeInteractionId");
LOG.debug("Received PostMessage with unknown ToKnowledgeInteractionId: "+aPostMsg.getToKnowledgeInteraction().toString());
CompletableFuture<ReactMessage> f = new CompletableFuture<>();
f.complete(m);
return f;
}

ReactKnowledgeInteraction reactKnowledgeInteraction;
reactKnowledgeInteraction = (ReactKnowledgeInteraction) knowledgeInteractionById.getKnowledgeInteraction();

Expand Down