Add smoke test to detect issues with Docker images#515
Merged
Sophietje merged 4 commits intoTNO:masterfrom Aug 20, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a smoke test/integration test to detect issues with the Docker images of the Knowledge Directory and the Smart Connector. It builds a Docker image for those components and starts a small example with a Knowledge Directory and two Knowledge Bases ( + Smart Connectors). After one minute it checks whether all containers of the example are still running, if not, then the test will fail.
The test will be run whenever a PR is made for the master branch, and when code is pushed to the master branch.
This should prevent issues such as #495. Resolves #499
A small note on the implementation, currently Docker buildx does not support the use of the
loadparameter with multi-arch images (see docker/buildx#59). Therefore, for this test, we build for a single platform.This workflow runs the Maven verify phase before it builds the Docker image.
I'm not sure whether this is really required. If not, we can remove it. Otherwise, we might consider integrating this into the other workflow such that the tests only need to run once.