Conversation
Next: - Add test for converter.
Also: - created simple unit test for creating the rule.
The function collects all fact rules into a single data rule.
In progress.
Additionally: - unit test for REST API - OpenAPI specification update - Improve Jena Rules.
There was a problem hiding this comment.
Two additional comments:
-
I'd recommend adding some tests for edge cases:
a) try to load an empty string/file
b) try and load a file with erroneous syntax
c) try and load a file with valid syntax but that contains something that we don't support (if that's even a thing, if so we should mention it in the docs) -
Do we support all syntax from Apache Jena's rule syntax? I saw something about the language tag somewhere. If not, we should include what syntax is supported in the documentation
Thanks for the review @Sophietje! A lot of good comments. Regarding the above comments: 1a) Added this case to |
No description provided.