Skip to content

616 domain knowledge facts rules should be loadable via the rest api#624

Merged
bnouwt merged 19 commits intomasterfrom
616-domain-knowledge-facts-rules-should-be-loadable-via-the-rest-api
Mar 10, 2025
Merged

616 domain knowledge facts rules should be loadable via the rest api#624
bnouwt merged 19 commits intomasterfrom
616-domain-knowledge-facts-rules-should-be-loadable-via-the-rest-api

Conversation

@bnouwt
Copy link
Copy Markdown
Collaborator

@bnouwt bnouwt commented Mar 3, 2025

No description provided.

bnouwt added 3 commits March 3, 2025 12:48
Also:
- created simple unit test for creating the rule.
@bnouwt bnouwt self-assigned this Mar 3, 2025
@bnouwt bnouwt linked an issue Mar 3, 2025 that may be closed by this pull request
@bnouwt bnouwt requested a review from Sophietje March 7, 2025 08:23
Copy link
Copy Markdown
Collaborator

@Sophietje Sophietje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two additional comments:

  1. I'd recommend adding some tests for edge cases:
    a) try to load an empty string/file
    b) try and load a file with erroneous syntax
    c) try and load a file with valid syntax but that contains something that we don't support (if that's even a thing, if so we should mention it in the docs)

  2. Do we support all syntax from Apache Jena's rule syntax? I saw something about the language tag somewhere. If not, we should include what syntax is supported in the documentation

Comment thread docs/docs/reasoning.md Outdated
Comment thread docs/docs/reasoning.md
Comment thread docs/docs/reasoning.md
Comment thread docs/docs/reasoning.md
Comment thread reasoner/src/main/java/eu/knowledge/engine/reasoner/util/JenaRules.java Outdated
Comment thread smart-connector-rest-server/src/main/resources/openapi-sc.yaml Outdated
@bnouwt
Copy link
Copy Markdown
Collaborator Author

bnouwt commented Mar 7, 2025

Two additional comments:

  1. I'd recommend adding some tests for edge cases:
    a) try to load an empty string/file
    b) try and load a file with erroneous syntax
    c) try and load a file with valid syntax but that contains something that we don't support (if that's even a thing, if so we should mention it in the docs)
  2. Do we support all syntax from Apache Jena's rule syntax? I saw something about the language tag somewhere. If not, we should include what syntax is supported in the documentation

Thanks for the review @Sophietje! A lot of good comments. Regarding the above comments:

1a) Added this case to eu.knowledge.engine.reasoner.api.JenaRuleConversionTest.
1b) This is already tested in eu.knowledge.engine.rest.api.TestDomainKnowledge.testDomainKnowledge().
1c) I've added tests and logic to deal with Builtin primitives which the TKE does not support.
2) I've added a tip about language tags in the documentation 👍

@bnouwt bnouwt requested a review from Sophietje March 7, 2025 20:28
Comment thread docs/docs/reasoning.md Outdated
Comment thread reasoner/src/main/java/eu/knowledge/engine/reasoner/util/JenaRules.java Outdated
@bnouwt bnouwt merged commit 7b1defb into master Mar 10, 2025
@bnouwt bnouwt deleted the 616-domain-knowledge-facts-rules-should-be-loadable-via-the-rest-api branch March 10, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Domain knowledge (facts + rules) should be loadable via the REST API.

2 participants