Skip to content

Improved error handling. #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnouwt merged 1 commit into from
Apr 11, 2025
Merged

Improved error handling. #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion smart-connector-api/src/main/java/eu/knowledge/engine/smartconnector/api/AnswerHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ public default CompletableFuture<BindingSet> answerAsync(AnswerKnowledgeInteract
BindingSet bs = this.answer(anAKI, anAnswerExchangeInfo);
future.complete(bs);
} catch (Exception e) {
LoggerFactory.getLogger(AnswerHandler.class).error("{}", e);
LoggerFactory.getLogger(AnswerHandler.class)
.error("Answering should not result in the following exception.", e);
future.completeExceptionally(e);
}
return future;
Expand Down
3 changes: 2 additions & 1 deletion smart-connector-api/src/main/java/eu/knowledge/engine/smartconnector/api/ReactHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ public default CompletableFuture<BindingSet> reactAsync(ReactKnowledgeInteractio
BindingSet bs = this.react(anRKI, aReactExchangeInfo);
future.complete(bs);
} catch (Exception e) {
LoggerFactory.getLogger(ReactHandler.class).error("{}", e);
LoggerFactory.getLogger(ReactHandler.class)
.error("Reacting should not result in the following exception.", e);
future.completeExceptionally(e);

}
Expand Down
5 changes: 3 additions & 2 deletions ...nnector/src/main/java/eu/knowledge/engine/smartconnector/impl/KnowledgeBaseStoreImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ public void unregister(ReactKnowledgeInteraction anReactKI) {
private void tryPut(MyKnowledgeInteractionInfo kii) throws IllegalArgumentException {
var existing = this.kiis.putIfAbsent(kii.id, kii);
if (existing != null) {
throw new IllegalArgumentException("A Knowledge Interaction with that URI was already registered.");
throw new IllegalArgumentException(
"The Knowledge Interaction with URI '" + kii.getId() + "' should not be already registered.");
}
}

Expand Down Expand Up @@ -243,7 +244,7 @@ private URI generateId(KnowledgeInteraction aKI, boolean isMeta) {
return new URI(this.getKnowledgeBaseId().toString() + "/interaction/" + aKI.getName());
} else {
return new URI(this.knowledgeBase.getKnowledgeBaseId().toString() + "/interaction/"
+ UUID.randomUUID().toString());
+ UUID.randomUUID().toString());
}
}
} catch (URISyntaxException e) {
Expand Down