Conversation
Done: - remove unnecessary imports - fix bug in BaseRule - create even simpeler transitivity unit test - create unit test for large binding set
There are still a lot of errors in reasoner tests, though.
Fixed a bug in the translate method that probably got mitigated by the generic merge that we did over every binding set. When we disabled this and really relied on the combi matches, it started to go wrong.
bnouwt
commented
Jul 1, 2025
Collaborator
Author
bnouwt
left a comment
bnouwt
left a comment
There was a problem hiding this comment.
Double checking the changes.
Sophietje
reviewed
Jul 2, 2025
bnouwt
deleted the
669-also-use-combimatch-to-improve-performance-of-binding-set-translation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.