Skip to content

Fixed a major bug in the Match.merge(...) method. #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnouwt merged 1 commit into from
Aug 22, 2025
Merged

Fixed a major bug in the Match.merge(...) method. #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions reasoner/src/main/java/eu/knowledge/engine/reasoner/Match.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,9 @@ private Map<TripleNode, TripleNode> mergeContexts(Map<TripleNode, TripleNode> ex
return null;
}
}
// no conflict, so we can safely put it into the mergedContext.
mergedContext.put(newEntry.getKey(), newEntry.getValue());

}
// no conflict, so we can safely put it into the mergedContext.
mergedContext.put(newEntry.getKey(), newEntry.getValue());
}

return mergedContext;
Expand Down
93 changes: 93 additions & 0 deletions reasoner/src/test/java/eu/knowledge/engine/reasoner/api/MatchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.math.BigInteger;
Expand All @@ -21,6 +22,7 @@
import org.junit.jupiter.api.TestInstance.Lifecycle;

import eu.knowledge.engine.reasoner.BaseRule;
import eu.knowledge.engine.reasoner.BaseRule.CombiMatch;
import eu.knowledge.engine.reasoner.BaseRule.MatchFlag;
import eu.knowledge.engine.reasoner.Match;
import eu.knowledge.engine.reasoner.ProactiveRule;
Expand Down Expand Up @@ -743,4 +745,95 @@ public void testNewGPMatcher2() {
assertEquals(7, matches.size());

}

@Test
public void testNewGPMatcher3() {

String gp = """
?operation <type> <HarvestingOperation> .
?operation <hasOutput> ?output .
?operation <isOperatedOn> ?parcel .
""";

Set<TriplePattern> obj1 = Util.toGP(gp);

String gp2 = """
?operation2 <type> <HarvestingOperation> .
?operation2 <hasOutput> ?output2 .
?operation2 <isOperatedOn> ?parcel2 .
""";

Set<TriplePattern> obj2 = Util.toGP(gp2);

String gp3 = """
?operation2 <type> <HarvestingOperation> .
?operation2 <hasOutput> ?output2 .
?operation2 <isOperatedOn> ?parcel2 .
""";

Set<TriplePattern> obj3 = Util.toGP(gp3);

BaseRule target = new ProactiveRule(new HashSet<>(), obj1);

BaseRule candidate1 = new Rule("candidate1", obj2, new SinkBindingSetHandler() {
public java.util.concurrent.CompletableFuture<Void> handle(BindingSet aBindingSet) {
return null;
};
});
BaseRule candidate2 = new Rule("candidate2", obj3, new SinkBindingSetHandler() {
public java.util.concurrent.CompletableFuture<Void> handle(BindingSet aBindingSet) {
return null;
};
});

HashSet<BaseRule> someCandidateRules = new HashSet<>(Arrays.asList(candidate1, candidate2));
Set<CombiMatch> combiMatches = BaseRule.getMatches(target, someCandidateRules, false,
EnumSet.of(MatchFlag.ONE_TO_ONE, MatchFlag.ONLY_BIGGEST, MatchFlag.SINGLE_RULE));

System.out.println("Size: " + combiMatches.size());
assertEquals(2, combiMatches.size());
}

@Test
public void testNewGPMatcher4() {

String gp = """
?operation <type> <HarvestingOperation> .
?operation <hasOutput> ?output .
?operation <isOperatedOn> ?parcel .
""";

Set<TriplePattern> obj1 = Util.toGP(gp);

String gp2 = """
?operation2 <type> <HarvestingOperation> .
?operation2 <hasOutput> ?output2 .
?operation2 <isOperatedOn> ?parcel2 .
""";

Set<TriplePattern> obj2 = Util.toGP(gp2);

BaseRule target = new ProactiveRule(new HashSet<>(), obj1);

BaseRule candidate1 = new Rule("candidate1", obj2, new SinkBindingSetHandler() {
public java.util.concurrent.CompletableFuture<Void> handle(BindingSet aBindingSet) {
return null;
};
});

HashSet<BaseRule> someCandidateRules = new HashSet<>(Arrays.asList(candidate1));
Set<CombiMatch> combiMatches = BaseRule.getMatches(target, someCandidateRules, false,
EnumSet.of(MatchFlag.ONE_TO_ONE, MatchFlag.ONLY_BIGGEST, MatchFlag.SINGLE_RULE));

CombiMatch cm = combiMatches.iterator().next();

Set<Match> matches = cm.get(candidate1);
assertNotNull(matches);

Match match = matches.iterator().next();
assertNotNull(match);

assertEquals(5, match.getMappings().size());

}
}