Fix loading of token validation endpoint variable#751
Merged
DaviddeBest-TNO merged 3 commits intomasterfrom Oct 20, 2025
Merged
Fix loading of token validation endpoint variable#751DaviddeBest-TNO merged 3 commits intomasterfrom
DaviddeBest-TNO merged 3 commits intomasterfrom
Conversation
bnouwt
reviewed
Oct 17, 2025
| # This is the knowledge directory, facilitating discovery between different | ||
| # runtimes. It exposes its service over port 8282. | ||
| knowledge-directory: | ||
| image: testkd:1.3.3-SNAPSHOT |
Collaborator
There was a problem hiding this comment.
These are no longer necessary so I took the liberty to replace them with the latest snapshot version of the smart connector docker image. Note that this version (1.3.3-SNAPSHOT) is not available and should be build locally.
When the next version of the knowledge engine is released. these should be set to non-snapshot versions.
bnouwt
approved these changes
Oct 17, 2025
Collaborator
bnouwt
left a comment
bnouwt
left a comment
There was a problem hiding this comment.
I've tested this version and it after some additional changes and building my own 1.3.3-SNAPSHOT version it works! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves loading of the token validation endpoint from the configuration and fixes EDC example