issue-7-stop-job #146
issue-7-stop-job #146
Conversation
|
|
| @Slf4j | ||
| @CompileStatic | ||
| @SlingServlet(methods = ['GET', 'PUT'], resourceTypes = ['twcable:grabbit/job']) | ||
| @SlingServlet(methods = ['GET', 'PUT', 'POST'], resourceTypes = ['twcable:grabbit/job']) |
There was a problem hiding this comment.
I'm kinda thinking 'DELETE' may be more appropriate in this case. What do you think @sagarsane @viveksachdeva ?
There was a problem hiding this comment.
Yeah that might be better...
There was a problem hiding this comment.
I used DELETE initially but changed it to POST... I thought that it is kind of an update... and I think of DELETE method as something for cleanup/removal... For me, ideal method for this would be PUT but that was used..
Open to change.. Thoughts??
There was a problem hiding this comment.
Yeah, I see your point.
I initially suggested the DELETE verb for removing jobs from the repository. If you remove a job from the repository, ideally you would make sure it is stopped as well (which we aren't doing currently in the clean servlet I don't think, but..); and possibly vice-versa. So, maybe we can consolidate stopping a job, and deleting a job in the future, because really having them be seperate concepts is sort of an artificial creation..
So I guess if I had to lean one way, it might be DELETE
Issue: #7
Added option to stop a job with given execution id...
Ready for review.
@jbornemann @jdigger @sagarsane @jayati-jt @Shashi-Bhushan