[BUGFIX] Enforce classic mode in created TYPO3 entrypoint files#661
Merged
[BUGFIX] Enforce classic mode in created TYPO3 entrypoint files#661
Conversation
`typo3/testing-framework` provides a extended `SystemEnvironmentBuilder` to ensure correct instance initialization as classic mode in different test context environment, allowing to manual set the composer mode flag despite having the PHP define from parent composer installation as source. `Testbase->setUpInstanceCoreLinks()` additionally provides TYPO3 entrypoints in form of index.php files, calling the basic bootstrap, based on template files from system extensions and modified to use the `typo3/testing-framework` `SystemEnvironmentBuilder` but does not enforce non-composer (classic) mode. This does not hurt within functional tests but codeception based accceptance instances misses the enforced classic mode which can lead to several issues, for example normalizedParams path calculation as basis for additional path or link generation. This change modifies the entrypoint creation code to reflect this need and forces non-composer mode. Releases: main, 8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typo3/testing-frameworkprovides a extendedSystemEnvironmentBuilderto ensure correct instance initialization as classic mode in different
test context environment, allowing to manual set the composer mode flag
despite having the PHP define from parent composer installation as source.
Testbase->setUpInstanceCoreLinks()additionally provides TYPO3 entrypointsin form of index.php files, calling the basic bootstrap, based on template
files from system extensions and modified to use the
typo3/testing-frameworkSystemEnvironmentBuilderbut does not enforce non-composer (classic) mode.This does not hurt within functional tests but codeception based accceptance
instances misses the enforced classic mode which can lead to several issues,
for example normalizedParams path calculation as basis for additional path
or link generation.
This change modifies the entrypoint creation code to reflect this need and
forces non-composer mode.
Releases: main, 8