[BUGFIX] Use the doctrine type instead of binding type in DataSet#691
Merged
[BUGFIX] Use the doctrine type instead of binding type in DataSet#691
DataSet#691Conversation
This change uses the doctrine type instead of the type bindingtype in `DataSet->import()` still ensuring that the value is encoded with current implementation within the TYPO3 Connection, while preparing to remove custom handling and using Doctrine DBAL behavour. With this modification both code paths are working. Additionally, the columnname is now used for the created types array effectly fixing a bug that this information has not been used and fallback to database schema was used anyway. Releases: main, 9, 8
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 11, 2025
Update `typo3/testing-framework` to have required code in place working with changes in extbase and TYPO3 Connection. Command(s): **main** > composer u 'typo3/testing-framework **13.4** > composer req --dev 'typo3/testing-framework':'^9.2.1' **12.4** > composer req --dev 'typo3/testing-framework':'^8.3.0' [1] TYPO3/testing-framework#690 [2] TYPO3/testing-framework#691 Resolves: #108039 Releases: main, 13.4, 12.4 Change-Id: I47c3b95b85a4940b1b034dbbd033cb868e01f5ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91483 Tested-by: core-ci <typo3@b13.com> Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Benjamin Franzke <ben@bnf.dev> Tested-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by: Benjamin Franzke <ben@bnf.dev> Reviewed-by: Stefan Bürk <stefan@buerk.tech>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 11, 2025
Update `typo3/testing-framework` to have required code in place working with changes in extbase and TYPO3 Connection. Command(s): **main** > composer u 'typo3/testing-framework **13.4** > composer req --dev 'typo3/testing-framework':'^9.2.1' **12.4** > composer req --dev 'typo3/testing-framework':'^8.3.0' [1] TYPO3/testing-framework#690 [2] TYPO3/testing-framework#691 Resolves: #108039 Releases: main, 13.4, 12.4 Change-Id: I47c3b95b85a4940b1b034dbbd033cb868e01f5ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91558 Tested-by: core-ci <typo3@b13.com> Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Stefan Bürk <stefan@buerk.tech>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 11, 2025
Update `typo3/testing-framework` to have required code in place working with changes in extbase and TYPO3 Connection. Command(s): **main** > composer u 'typo3/testing-framework **13.4** > composer req --dev 'typo3/testing-framework':'^9.2.1' **12.4** > composer req --dev 'typo3/testing-framework':'^8.3.1' [1] TYPO3/testing-framework#690 [2] TYPO3/testing-framework#691 Resolves: #108039 Releases: main, 13.4, 12.4 Change-Id: I47c3b95b85a4940b1b034dbbd033cb868e01f5ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91559 Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: core-ci <typo3@b13.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses the doctrine type instead of the type
bindingtype in
DataSet->import()still ensuring thatthe value is encoded with current implementation within
the TYPO3 Connection, while preparing to remove custom
handling and using Doctrine DBAL behavour. With this
modification both code paths are working.
Additionally, the columnname is now used for the created
types array effectly fixing a bug that this information
has not been used and fallback to database schema was
used anyway.
Releases: main, 9, 8