Skip to content

Fix notes to note #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KrishnaSolo merged 2 commits into from
Apr 22, 2021
Merged

Fix notes to note #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc5a677
Updated post and put for notes to use singular note - was missed earl…
KrishnaSolo Apr 21, 2021
f3ba9f1
fixed up logging to be better - will need to apply this to other lamb…
KrishnaSolo Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions takeNotes-src/postNote/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ function isValidRequest(context, event) {
event.pathParameters.id !== null;

let body = event.body;
let isBodyValid = body !== null && body.notes !== null;
let isBodyValid = body !== null && body.note !== null;

return isIdValid && isBodyValid;
}

function updateRecord(recordId, eventBody, id) {
let d = new Date();
console.log("record id: " + recordId + " eventBody: " + eventBody.notes);
console.log("record id: ", recordId, " eventBody: ", eventBody.note);
let noteBody = eventBody.note;

const metaFields = {
Expand All @@ -63,14 +63,13 @@ function updateRecord(recordId, eventBody, id) {
ConditionExpression: "attribute_not_exists(docBody.notes.#noteId)",
ReturnValues: "ALL_NEW",
};
console.log("params: " + params);
console.log("params: ", params);
return docClient.update(params);
}

// Lambda Handler
exports.postNote = async (event, context, callback) => {
console.log("event: " + event);
console.log("body: " + event.body);
console.log("event: ", event);
if (!isValidRequest(context, event)) {
return response(400, { message: "Error: Invalid request" });
}
Expand Down
10 changes: 5 additions & 5 deletions takeNotes-src/putNotes/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function isValidRequest(context, event) {

function updateRecord(recordId, eventBody, noteIdx) {
let d = new Date();
console.log("record id: " + recordId + " eventBody: " + eventBody.notes);
console.log("record id: ", recordId, " eventBody: ", eventBody.note);
const params = {
TableName: TABLE_NAME,
Key: {
Expand All @@ -49,19 +49,19 @@ function updateRecord(recordId, eventBody, noteIdx) {
ExpressionAttributeNames: { "#noteId": noteIdx },
ExpressionAttributeValues: {
":u": d.toISOString(),
":n": eventBody.notes,
":n": eventBody.note,
},
ConditionExpression: "attribute_exists(docBody.notes.#noteId)",
ReturnValues: "ALL_NEW",
};
console.log("params: " + params);
console.log("params: ", params);
return docClient.update(params);
}

// Lambda Handler
exports.putNotes = async (event, context, callback) => {
console.log("event: " + event);
console.log("body: " + event.body);
console.log("event: ", event);
console.log("body: ", event.body);
if (!isValidRequest(context, event)) {
return response(400, { message: "Error: Invalid request" });
}
Expand Down