Conversation
Code Review - PR #170🟡 Code Quality & Best PracticesInconsistency: ChannelsAPI.cs:23, 38, 62 - The While
Impact: If users intentionally include leading/trailing spaces in property keys/values, those will now be silently removed. This is a breaking change in behavior. Suggestion: Apply trimming selectively before adding to dictionary, not in the LINQ select. 🔵 Performance ConsiderationsMinor: Trim called multiple times in LINQ The ✅ Security & Other Categories
Overall: The URL encoding addition is a good security improvement. Main concern is the implicit trimming behavior change for user-provided values. |
No description provided.