Skip to content

chore: force cache bust#381

Merged
SeanCassiere merged 1 commit into
TanStack:mainfrom
beaussan:patch-1
May 11, 2026
Merged

chore: force cache bust#381
SeanCassiere merged 1 commit into
TanStack:mainfrom
beaussan:patch-1

Conversation

@beaussan
Copy link
Copy Markdown
Contributor

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@SeanCassiere SeanCassiere merged commit d5a7dcc into TanStack:main May 11, 2026
3 of 5 checks passed
@slorber
Copy link
Copy Markdown

slorber commented May 12, 2026

Hey, just wondering, why not completely ignore caches when you are in a release workflow?

To me, this is safer to never use any cache in publish workflows. It's better to be secure than faster.

We disabled cache on Docusaurus workflow for that reason: facebook/docusaurus#11795

@SeanCassiere
Copy link
Copy Markdown
Member

Hey, just wondering, why not completely ignore caches when you are in a release workflow?

To me, this is safer to never use any cache in publish workflows. It's better to be secure than faster.

We disabled cache on Docusaurus workflow for that reason: facebook/docusaurus#11795

We're definitely in agreement there. It's on our list of things to action. We're also weighing the option of nuking cache in general.

On this, we should have consensus on a decision soon and we'll roll out something soon to harden stuff across the packages.

@SeanCassiere
Copy link
Copy Markdown
Member

Turned it off for now anyways - 47d572f

@slorber
Copy link
Copy Markdown

slorber commented May 12, 2026

👍

See also this related GitHub Actions discussion: https://github.com/orgs/community/discussions/194493

@SeanCassiere
Copy link
Copy Markdown
Member

👍

See also this related GitHub Actions discussion: https://github.com/orgs/community/discussions/194493

Thanks for the heads up on this 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants