[repro] writeUpdate persists on remount for on-demand collections (issue #1152) by claude[bot] · Pull Request #1154 · TanStack/db

claude · 2026-01-19T13:48:51Z

Summary

Reproduction test for issue #1152.

Adds tests that verify writeUpdate on on-demand collections with computed query keys properly updates all active query caches so data persists when components remount.

Tests cover three scenarios:

Function-based computed queryKey with predicates - Uses queryKey: (opts) => [...] where the key changes based on predicates
Static queryKey with on-demand mode and where clause - Uses static queryKey: ['collection'] but predicates get appended in on-demand mode
Function queryKey that returns constant value - Uses queryKey: () => ['collection'] (constant)

How to run:

pnpm --filter @tanstack/query-db-collection test -- --run 'issue #1152'

Observed failure:

2 out of 3 tests fail with:

AssertionError: expected 'Item 1' to be 'Updated Item 1'

This demonstrates that after using writeUpdate and then remounting (cleanup + recreate live query), the updated data is lost because the cache was updated at the wrong query key.

What the tests assert:

After calling collection.utils.writeUpdate() on an item
The collection should reflect the update immediately ✅
After cleaning up the live query and recreating it (simulating remount)
The collection should still show the updated data ❌ (fails due to bug)

Fixes: #1152

…s (issue #1152) Add tests that verify writeUpdate on on-demand collections with computed query keys properly updates all active query caches so data persists when components remount. Tests cover three scenarios: 1. Function-based computed queryKey with predicates 2. Static queryKey with on-demand mode and where clause 3. Function queryKey that returns constant value These tests currently fail, demonstrating the bug where writeUpdate updates the wrong cache key (base key instead of predicate-specific keys). Co-Authored-By: Claude <noreply@anthropic.com>

changeset-bot · 2026-01-19T13:48:56Z

⚠️ No Changeset found

Latest commit: 9868bc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new · 2026-01-19T13:51:26Z

More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@1154

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@1154

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@1154

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@1154

@tanstack/offline-transactions

npm i https://pkg.pr.new/@tanstack/offline-transactions@1154

@tanstack/powersync-db-collection

npm i https://pkg.pr.new/@tanstack/powersync-db-collection@1154

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@1154

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@1154

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@1154

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@1154

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@1154

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@1154

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@1154

commit: 9868bc2

github-actions · 2026-01-19T13:52:04Z

Size Change: 0 B

Total Size: 90.5 kB

ℹ️ View Unchanged

Filename	Size
`./packages/db/dist/esm/collection/change-events.js`	1.39 kB
`./packages/db/dist/esm/collection/changes.js`	1.19 kB
`./packages/db/dist/esm/collection/events.js`	388 B
`./packages/db/dist/esm/collection/index.js`	3.32 kB
`./packages/db/dist/esm/collection/indexes.js`	1.1 kB
`./packages/db/dist/esm/collection/lifecycle.js`	1.67 kB
`./packages/db/dist/esm/collection/mutations.js`	2.34 kB
`./packages/db/dist/esm/collection/state.js`	3.46 kB
`./packages/db/dist/esm/collection/subscription.js`	3.62 kB
`./packages/db/dist/esm/collection/sync.js`	2.38 kB
`./packages/db/dist/esm/deferred.js`	207 B
`./packages/db/dist/esm/errors.js`	4.49 kB
`./packages/db/dist/esm/event-emitter.js`	748 B
`./packages/db/dist/esm/index.js`	2.69 kB
`./packages/db/dist/esm/indexes/auto-index.js`	742 B
`./packages/db/dist/esm/indexes/base-index.js`	766 B
`./packages/db/dist/esm/indexes/btree-index.js`	1.93 kB
`./packages/db/dist/esm/indexes/lazy-index.js`	1.1 kB
`./packages/db/dist/esm/indexes/reverse-index.js`	513 B
`./packages/db/dist/esm/local-only.js`	837 B
`./packages/db/dist/esm/local-storage.js`	2.1 kB
`./packages/db/dist/esm/optimistic-action.js`	359 B
`./packages/db/dist/esm/paced-mutations.js`	496 B
`./packages/db/dist/esm/proxy.js`	3.75 kB
`./packages/db/dist/esm/query/builder/functions.js`	733 B
`./packages/db/dist/esm/query/builder/index.js`	4.08 kB
`./packages/db/dist/esm/query/builder/ref-proxy.js`	1.05 kB
`./packages/db/dist/esm/query/compiler/evaluators.js`	1.42 kB
`./packages/db/dist/esm/query/compiler/expressions.js`	430 B
`./packages/db/dist/esm/query/compiler/group-by.js`	1.87 kB
`./packages/db/dist/esm/query/compiler/index.js`	1.96 kB
`./packages/db/dist/esm/query/compiler/joins.js`	2 kB
`./packages/db/dist/esm/query/compiler/order-by.js`	1.45 kB
`./packages/db/dist/esm/query/compiler/select.js`	1.06 kB
`./packages/db/dist/esm/query/expression-helpers.js`	1.43 kB
`./packages/db/dist/esm/query/ir.js`	673 B
`./packages/db/dist/esm/query/live-query-collection.js`	360 B
`./packages/db/dist/esm/query/live/collection-config-builder.js`	5.4 kB
`./packages/db/dist/esm/query/live/collection-registry.js`	264 B
`./packages/db/dist/esm/query/live/collection-subscriber.js`	1.93 kB
`./packages/db/dist/esm/query/live/internal.js`	145 B
`./packages/db/dist/esm/query/optimizer.js`	2.56 kB
`./packages/db/dist/esm/query/predicate-utils.js`	2.97 kB
`./packages/db/dist/esm/query/subset-dedupe.js`	921 B
`./packages/db/dist/esm/scheduler.js`	1.3 kB
`./packages/db/dist/esm/SortedMap.js`	1.3 kB
`./packages/db/dist/esm/strategies/debounceStrategy.js`	247 B
`./packages/db/dist/esm/strategies/queueStrategy.js`	428 B
`./packages/db/dist/esm/strategies/throttleStrategy.js`	246 B
`./packages/db/dist/esm/transactions.js`	2.9 kB
`./packages/db/dist/esm/utils.js`	924 B
`./packages/db/dist/esm/utils/browser-polyfills.js`	304 B
`./packages/db/dist/esm/utils/btree.js`	5.61 kB
`./packages/db/dist/esm/utils/comparison.js`	852 B
`./packages/db/dist/esm/utils/cursor.js`	457 B
`./packages/db/dist/esm/utils/index-optimization.js`	1.51 kB
`./packages/db/dist/esm/utils/type-guards.js`	157 B

_{compressed-size-action::db-package-size}

github-actions · 2026-01-19T13:52:41Z

Size Change: 0 B

Total Size: 3.47 kB

ℹ️ View Unchanged

Filename	Size
`./packages/react-db/dist/esm/index.js`	225 B
`./packages/react-db/dist/esm/useLiveInfiniteQuery.js`	1.17 kB
`./packages/react-db/dist/esm/useLiveQuery.js`	1.12 kB
`./packages/react-db/dist/esm/useLiveSuspenseQuery.js`	559 B
`./packages/react-db/dist/esm/usePacedMutations.js`	401 B

_{compressed-size-action::react-db-package-size}

kevin-dp · 2026-01-20T08:49:23Z

Closing this one as we will merge the fix (#1155) which includes this reproduction straight into main.

ci: apply automated fixes

9868bc2

This was referenced Jan 19, 2026

[fix] update all active query caches on directWrite for on-demand collections (issue #1152) #1155

Merged

[QueryCollection]: on-demand collections directWrite to unknown query keys #1152

Closed

kevin-dp closed this Jan 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[repro] writeUpdate persists on remount for on-demand collections (issue #1152)#1154

[repro] writeUpdate persists on remount for on-demand collections (issue #1152)#1154
claude[bot] wants to merge 2 commits intomainfrom
ai/issue-1152-repro

claude bot commented Jan 19, 2026

Uh oh!

changeset-bot bot commented Jan 19, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

kevin-dp commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

claude bot commented Jan 19, 2026

Summary

Tests cover three scenarios:

How to run:

Observed failure:

What the tests assert:

Uh oh!

changeset-bot bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

pkg-pr-new bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

kevin-dp commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot bot commented Jan 19, 2026 •

edited

Loading