fix: make item drafts mutable#408
Conversation
|
Since we're only using 1 type from it, first reaction would be to vendor it in. But, it's a type so we could make it a dev dependency in which case i'm less worried about the additional dependency (cc @samwillis). |
|
Tbh I'm not sure about npm packaging and was wondering whether I should put this in |
|
@pawelblaszczyk5 Indeed, i might be wrong here. It may need to be a regular dependency because the type is needed by the users of our library. In that case, i think it's best to vendor in that one type. |
|
Yep, I would prefer to vendor a minimal type helper for this rather than have a dependancy. We are aiming for almost no dependancies (we only depend on standard schema at the moment). |
|
I’ll change that then, thanks :) |
c3052ce to
0de4650
Compare
🦋 Changeset detectedLatest commit: c356557 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I changed it - venodred the type from |
More templates
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Closes #407
I wasn't sure whether it's fine to install dependency for it, or just copy paste it (but the type is a little bit bulky). As this type unfortunately has a lot of weird edge cases 😅 Lmk if you'd prefer to avoid the dependency!