Skip to content

fix disabling of gc by settings gcTime=0#463

Merged
samwillis merged 4 commits intomainfrom
samwillis/fix-gc
Aug 27, 2025
Merged

fix disabling of gc by settings gcTime=0#463
samwillis merged 4 commits intomainfrom
samwillis/fix-gc

Conversation

@samwillis
Copy link
Collaborator

@samwillis samwillis commented Aug 27, 2025

The intention was that setting gcTime=0 would disable it, this was not true.

I've also added tests to the electric collection to validate that it will restart the sync after being GC'd and resubscribed too.

@samwillis samwillis requested a review from kevin-dp August 27, 2025 14:45
@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2025

🦋 Changeset detected

Latest commit: b73d509

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@tanstack/electric-db-collection Patch
@tanstack/db Patch
@tanstack/query-db-collection Patch
@tanstack/react-db Patch
@tanstack/solid-db Patch
@tanstack/svelte-db Patch
@tanstack/trailbase-db-collection Patch
@tanstack/vue-db Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 27, 2025

More templates

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@463

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@463

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@463

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@463

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@463

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@463

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@463

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@463

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@463

commit: b73d509

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

Size Change: 0 B

Total Size: 64.6 kB

ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/change-events.js 1.13 kB
./packages/db/dist/esm/collection.js 10.6 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 3 kB
./packages/db/dist/esm/index.js 1.52 kB
./packages/db/dist/esm/indexes/auto-index.js 745 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.74 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.03 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 4.19 kB
./packages/db/dist/esm/query/builder/functions.js 575 B
./packages/db/dist/esm/query/builder/index.js 3.79 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 890 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.48 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.06 kB
./packages/db/dist/esm/query/compiler/index.js 2.15 kB
./packages/db/dist/esm/query/compiler/joins.js 2.36 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.17 kB
./packages/db/dist/esm/query/compiler/select.js 655 B
./packages/db/dist/esm/query/ir.js 466 B
./packages/db/dist/esm/query/live-query-collection.js 333 B
./packages/db/dist/esm/query/live/collection-config-builder.js 2.56 kB
./packages/db/dist/esm/query/live/collection-subscriber.js 2.4 kB
./packages/db/dist/esm/query/optimizer.js 2.63 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 2.29 kB
./packages/db/dist/esm/utils.js 419 B
./packages/db/dist/esm/utils/btree.js 6.02 kB
./packages/db/dist/esm/utils/comparison.js 718 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

Size Change: 0 B

Total Size: 1.16 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.01 kB

compressed-size-action::react-db-package-size

Copy link
Contributor

@kevin-dp kevin-dp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

"@tanstack/db": patch
---

fix disabling of gc by settings `gcTime: 0` on the collection options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:

settings

@samwillis samwillis merged commit 4d20004 into main Aug 27, 2025
5 checks passed
@samwillis samwillis deleted the samwillis/fix-gc branch August 27, 2025 14:59
@github-actions github-actions bot mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants