Skip to content

Fix structural hashing of numbers#525

Merged
kevin-dp merged 3 commits intomainfrom
kevin/fix-structural-hashing-of-numbers
Sep 11, 2025
Merged

Fix structural hashing of numbers#525
kevin-dp merged 3 commits intomainfrom
kevin/fix-structural-hashing-of-numbers

Conversation

@kevin-dp
Copy link
Contributor

@kevin-dp kevin-dp commented Sep 10, 2025

Reproduces and fixes #517

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025

🦋 Changeset detected

Latest commit: 27c8343

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 10, 2025

More templates

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@525

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@525

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@525

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@525

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@525

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@525

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@525

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@525

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@525

commit: 27c8343

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 66.6 kB

ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/change-events.js 1.13 kB
./packages/db/dist/esm/collection.js 10.5 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 3.1 kB
./packages/db/dist/esm/index.js 1.55 kB
./packages/db/dist/esm/indexes/auto-index.js 745 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.74 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.03 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 3.87 kB
./packages/db/dist/esm/query/builder/functions.js 615 B
./packages/db/dist/esm/query/builder/index.js 3.93 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 938 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.52 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.08 kB
./packages/db/dist/esm/query/compiler/index.js 2.27 kB
./packages/db/dist/esm/query/compiler/joins.js 2.5 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.23 kB
./packages/db/dist/esm/query/compiler/select.js 1.28 kB
./packages/db/dist/esm/query/ir.js 508 B
./packages/db/dist/esm/query/live-query-collection.js 333 B
./packages/db/dist/esm/query/live/collection-config-builder.js 2.59 kB
./packages/db/dist/esm/query/live/collection-subscriber.js 2.4 kB
./packages/db/dist/esm/query/optimizer.js 3.05 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 2.29 kB
./packages/db/dist/esm/utils.js 943 B
./packages/db/dist/esm/utils/btree.js 6.02 kB
./packages/db/dist/esm/utils/comparison.js 718 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 1.18 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.02 kB

compressed-size-action::react-db-package-size

Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it we had to use the array buffer?

LGTM

@kevin-dp
Copy link
Contributor Author

I take it we had to use the array buffer?

LGTM

Yes, bitwise operators cast the number to 32 bit integer so can't use those. So instead have to explicitly use an array buffer, but we allocate them only once and then mutate them.

@kevin-dp kevin-dp merged commit a9878ad into main Sep 11, 2025
6 checks passed
@kevin-dp kevin-dp deleted the kevin/fix-structural-hashing-of-numbers branch September 11, 2025 10:04
@github-actions github-actions bot mentioned this pull request Sep 11, 2025
Uziniii pushed a commit to Uziniii/db that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

structural hashing truncates numbers to their integer part

2 participants