fix stuck loading state after an electric must-refetch#532
Merged
Conversation
🦋 Changeset detectedLatest commit: f67d98a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samwillis
requested review from
KyleAMathews and
kevin-dp
and removed request for
kevin-dp
samwillis
commented
Sep 11, 2025
Comment on lines
+401
to
+405
| // Always notify dependents when markReady is called, after status is set | ||
| // This ensures live queries get notified when their dependencies become ready | ||
| if (this.changeListeners.size > 0) { | ||
| this.emitEmptyReadyEvent() | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This is the fix for the stuck loading state
samwillis
commented
Sep 11, 2025
Comment on lines
+1275
to
+1280
| // 3) Clear currentVisibleState for truncated keys to ensure subsequent operations | ||
| // are compared against the post-truncate state (undefined) rather than pre-truncate state | ||
| // This ensures that re-inserted keys are emitted as INSERT events, not UPDATE events | ||
| for (const key of changedKeys) { | ||
| currentVisibleState.delete(key) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This is the fix for the inconsistent state
More templates
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
samwillis
commented
Sep 11, 2025
| electricCollection = createElectricUsersCollection() | ||
| }) | ||
|
|
||
| it(`should handle basic must-refetch with filtered live query`, () => { |
Collaborator
Author
There was a problem hiding this comment.
this test failed before the fix, it showed an inconstant state
samwillis
commented
Sep 11, 2025
| expect(liveQuery.size).toBe(1) | ||
| }) | ||
|
|
||
| it(`should handle live query becoming ready after must-refetch during initial sync`, () => { |
Collaborator
Author
There was a problem hiding this comment.
this reproduced the stuck loading state
Contributor
|
Size Change: 0 B Total Size: 66.6 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 1.18 kB ℹ️ View Unchanged
|
kevin-dp
approved these changes
Sep 11, 2025
Contributor
kevin-dp
left a comment
kevin-dp
left a comment
There was a problem hiding this comment.
Great find! Love it when the fixes are simple.
alco
reviewed
Sep 11, 2025
packages/electric-db-collection/tests/electric-live-query.test.ts
Outdated
Show resolved
Hide resolved
samwillis
force-pushed
the
samwillis/stuck-loading-state
branch
from
fa49a6b to
ed9686a
Compare
KyleAMathews
approved these changes
Sep 11, 2025
Collaborator
KyleAMathews
left a comment
KyleAMathews
left a comment
There was a problem hiding this comment.
Nice! Very intricate little web we've spun now haha — fine details matter
Merged
Uziniii
pushed a commit
to Uziniii/db
that referenced
this pull request
Sep 19, 2025
This was referenced Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also fixes an inconstant state bug.