Skip to content

Fix joins using conditions with computed values#595

Merged
samwillis merged 3 commits intoTanStack:mainfrom
duailibe:join-concat
Sep 29, 2025
Merged

Fix joins using conditions with computed values#595
samwillis merged 3 commits intoTanStack:mainfrom
duailibe:join-concat

Conversation

@duailibe
Copy link
Contributor

@duailibe duailibe commented Sep 26, 2025

Fix joins using conditions with computed values like `concat()` by preventing optimization that causes type mismatches in followRef

Fixes #592

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2025

🦋 Changeset detected

Latest commit: d1e9970

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@tanstack/db Patch
@tanstack/angular-db Patch
@tanstack/electric-db-collection Patch
@tanstack/query-db-collection Patch
@tanstack/react-db Patch
@tanstack/rxdb-db-collection Patch
@tanstack/solid-db Patch
@tanstack/svelte-db Patch
@tanstack/trailbase-db-collection Patch
@tanstack/vue-db Patch
todos Patch
@tanstack/db-example-react-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samwillis
Copy link
Collaborator

Thanks @duailibe! This look correct to me but I'm going to ask @kevin-dp to cast his eyes over it as he worked on the optimisations.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 26, 2025

More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@595

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@595

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@595

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@595

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@595

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@595

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@595

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@595

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@595

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@595

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@595

commit: d1e9970

Copy link
Contributor

@kevin-dp kevin-dp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this problem and fixing it!

@samwillis samwillis merged commit ce7e2b2 into TanStack:main Sep 29, 2025
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 29, 2025
@duailibe duailibe deleted the join-concat branch September 29, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when joining with a computed value

3 participants