Skip to content

fix: prevent manually setting derived meta#1480

Merged
Balastrong merged 1 commit intoTanStack:mainfrom
Balastrong:fix/set-meta-base-only
May 6, 2025
Merged

fix: prevent manually setting derived meta#1480
Balastrong merged 1 commit intoTanStack:mainfrom
Balastrong:fix/set-meta-base-only

Conversation

@Balastrong
Copy link
Copy Markdown
Member

Technically a breaking change on the types, but I feel manually setting derived meta (like errors) shouldn't be allowed as they would get overridden in the next update anyway.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 6, 2025

View your CI Pipeline Execution ↗ for commit d1e1855.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 32s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 07:29:55 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1480

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1480

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1480

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1480

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1480

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1480

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1480

commit: d1e1855

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (8634cee) to head (d1e1855).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1480   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files          31       31           
  Lines        1398     1398           
  Branches      353      353           
=======================================
  Hits         1244     1244           
  Misses        137      137           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Balastrong Balastrong merged commit 5319847 into TanStack:main May 6, 2025
6 checks passed
@Balastrong Balastrong deleted the fix/set-meta-base-only branch May 6, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant