Skip to content

chore: remove svelte tsconfig explicit path to form-core#1483

Merged
Balastrong merged 1 commit intoTanStack:mainfrom
Balastrong:chore/remove-unnecessary-path
May 6, 2025
Merged

chore: remove svelte tsconfig explicit path to form-core#1483
Balastrong merged 1 commit intoTanStack:mainfrom
Balastrong:chore/remove-unnecessary-path

Conversation

@Balastrong
Copy link
Copy Markdown
Member

For some reason this generates .d.ts files on form-core when building svelte. I don't think this config is needed anyway as form-core is already from workspace:* in package.json

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 6, 2025

View your CI Pipeline Execution ↗ for commit 2a12af5.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 26s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 21:19:42 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1483

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1483

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1483

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1483

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1483

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1483

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1483

commit: 2a12af5

@Balastrong Balastrong merged commit 3fe66dd into TanStack:main May 6, 2025
4 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (1920ade) to head (2a12af5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1483      +/-   ##
==========================================
+ Coverage   88.98%   92.85%   +3.87%     
==========================================
  Files          31        3      -28     
  Lines        1398       42    -1356     
  Branches      353        1     -352     
==========================================
- Hits         1244       39    -1205     
+ Misses        137        3     -134     
+ Partials       17        0      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant