test(svelte-query/createQueries): move type tests from 'createQueries.svelte.test.ts' to 'createQueries.test-d.ts' by sukvvon · Pull Request #10389 · TanStack/query

sukvvon · 2026-04-05T10:47:28Z

🎯 Changes

Move 4 pure type tests from createQueries.svelte.test.ts to createQueries.test-d.ts
- handles type parameter - tuple of tuples
- handles type parameter - tuple of objects
- handles array literal without type parameter to infer result type
- handles strongly typed queryFn factories and createQueries wrappers
Remove expectTypeOf, withEffectRoot wrapper, and unused type imports from runtime test file
Follows the existing svelte-query pattern of separating runtime tests (.svelte.test.ts) from type tests (.test-d.ts)

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Reorganized type-safety test coverage for createQueries, expanding validation of generic parameter handling and type inference scenarios to ensure robust typing behavior across tuple-based and array-based query configurations.

….svelte.test.ts' to 'createQueries.test-d.ts'

coderabbitai · 2026-04-05T10:47:45Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 40f8a849-5338-4fa0-842b-efbcd5785b82

📥 Commits

Reviewing files that changed from the base of the PR and between 7781a3e and 5d475fa.

📒 Files selected for processing (2)

packages/svelte-query/tests/createQueries/createQueries.svelte.test.ts
packages/svelte-query/tests/createQueries/createQueries.test-d.ts

📝 Walkthrough

Walkthrough

The pull request reorganizes type-level test coverage for the createQueries function across two test files. Type-checking tests and associated imports are removed from the main test file, while comprehensive type-test coverage is added to a dedicated type-test file with expanded test scenarios.

Changes

Cohort / File(s)	Summary
Type Test Removal `packages/svelte-query/tests/createQueries/createQueries.svelte.test.ts`	Removed unused imports (`expectTypeOf` and several type imports), deleted three large test blocks performing compile-time type assertions using `expectTypeOf`. Runtime tests and `CreateQueryResult` usage remain unchanged.
Type Test Addition `packages/svelte-query/tests/createQueries/createQueries.test-d.ts`	Expanded type-test coverage by importing additional public types and QueryClient, adding comprehensive test cases for generic parameter handling (tuples/objects), type inference for array literals, and strongly typed `queryFn` factories with validation of TypeScript error expectations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

test(svelte-query/createQueries): move test files into 'createQueries' directory #10386: Directly modifies the same createQueries test suite, adjusting type-testing assertions and imports across the Svelte and .test-d.ts files.

Poem

🐰 Tests hop from one warren to another,
Type checks dance in files so fine,
Organized with care, we recover,
Coverage blooms in each design! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: moving type tests from one file to another, with clear specificity about which files and what type of tests.
Description check	✅ Passed	The description includes all required sections from the template (Changes, Checklist, Release Impact) with detailed information about what was moved and why.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/svelte-query-createQueries-move-type-tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-05T10:47:52Z

View your CI Pipeline Execution ↗ for commit 5d475fa

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	34s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-05 10:50:34 UTC

github-actions · 2026-04-05T10:48:18Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-05T10:50:26Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10389

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10389

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10389

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10389

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10389

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10389

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10389

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10389

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10389

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10389

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10389

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10389

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10389

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10389

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10389

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10389

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10389

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10389

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10389

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10389

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10389

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10389

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10389

commit: 5d475fa

github-actions · 2026-04-05T10:50:35Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	9.01 KB (0%)

test(svelte-query/createQueries): move type tests from 'createQueries…

6f16707

….svelte.test.ts' to 'createQueries.test-d.ts'

github-actions Bot added the package: svelte-query label Apr 5, 2026

ci: apply automated fixes

5d475fa

sukvvon self-assigned this Apr 5, 2026

sukvvon merged commit 80f0370 into main Apr 5, 2026
8 checks passed

sukvvon deleted the test/svelte-query-createQueries-move-type-tests branch April 5, 2026 11:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(svelte-query/createQueries): move type tests from 'createQueries.svelte.test.ts' to 'createQueries.test-d.ts'#10389

test(svelte-query/createQueries): move type tests from 'createQueries.svelte.test.ts' to 'createQueries.test-d.ts'#10389
sukvvon merged 2 commits intomainfrom
test/svelte-query-createQueries-move-type-tests

sukvvon commented Apr 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 5, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloud Bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Apr 5, 2026

Uh oh!

github-actions Bot commented Apr 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloud Bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Apr 5, 2026

Uh oh!

github-actions Bot commented Apr 5, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 5, 2026 •

edited

Loading

nx-cloud Bot commented Apr 5, 2026 •

edited

Loading

github-actions Bot commented Apr 5, 2026 •

edited

Loading