Skip to content

test(angular-query-experimental/injectQuery): remove duplicate error test already covered by 'should reject and update signal'#10588

Merged
sukvvon merged 1 commit intomainfrom
test/angular-query-inject-query-remove-duplicate-error-test
Apr 26, 2026
Merged

test(angular-query-experimental/injectQuery): remove duplicate error test already covered by 'should reject and update signal'#10588
sukvvon merged 1 commit intomainfrom
test/angular-query-inject-query-remove-duplicate-error-test

Conversation

@sukvvon
Copy link
Copy Markdown
Collaborator

@sukvvon sukvvon commented Apr 26, 2026 •
edited by coderabbitai Bot
Loading

🎯 Changes

Remove should set state to error when queryFn returns reject promise from injectQuery tests. Its scenario (retry: false + a queryFn that rejects → status: 'error') is already fully covered by should reject and update signal, which uses the same setup and additionally asserts data, error, isPending, isFetching, isError, failureCount, and failureReason. The only piece the deleted test still exercised was the initial status: 'pending' check, and that is already covered by should return pending status initially.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Tests
    • Removed a test case for query rejection behavior validation.

Note: This change is a test infrastructure update with no impact on user-facing functionality.

@sukvvon
test(angular-query-experimental/injectQuery): remove duplicate error …
93141db 
…test already covered by 'should reject and update signal'
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 16c65099-b8a5-4e81-a5e4-6f66d54f425e

📥 Commits

Reviewing files that changed from the base of the PR and between 76161b7 and 93141db.

📒 Files selected for processing (1)
  • packages/angular-query-experimental/src/__tests__/inject-query.test.ts
💤 Files with no reviewable changes (1)
  • packages/angular-query-experimental/src/tests/inject-query.test.ts
📝 Walkthrough

Walkthrough

A test case verifying rejection behavior in injectQuery was deleted. The removed test asserted that when queryFn returns a rejected Promise with retry: false, the query status transitions from pending to error.

Changes

Cohort / File(s) Summary
Test Removal
packages/angular-query-experimental/src/__tests__/inject-query.test.ts		 Deleted a test case asserting injectQuery status transition from pending to error when queryFn returns a rejected Promise with retry: false.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A test bid farewell, no longer needed,
Eighteen lines removed where once they pleaded,
The rejection case hops away with grace,
Making room for tests of proper pace. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a duplicate error test that is already covered by another test.
Description check ✅ Passed The description is well-structured, follows the template with all required sections completed, and provides clear context for the test removal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/angular-query-inject-query-remove-duplicate-error-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@sukvvon sukvvon self-assigned this Apr 26, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 26, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 93141db

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 8s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-26 05:51:25 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 26, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 26, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10588

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10588

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10588

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10588

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10588

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10588

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10588

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10588

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10588

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10588

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10588

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10588

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10588

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10588

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10588

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10588

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10588

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10588

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10588

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10588

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10588

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10588

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10588

commit: 93141db

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 26, 2026

size-limit report 📦

Path Size
react full 12.1 KB (0%)
react minimal 9.07 KB (0%)

@sukvvon sukvvon merged commit d78883b into main Apr 26, 2026
10 checks passed
@sukvvon sukvvon deleted the test/angular-query-inject-query-remove-duplicate-error-test branch April 26, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sukvvon sukvvon

Labels

package: angular-query-experimental

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon