Skip to content

test(preact-query/ErrorBoundary): replace British 'behaviour' with American 'behavior'#10605

Merged
sukvvon merged 1 commit intomainfrom
test/preact-query-error-boundary-fix-british-spelling
Apr 28, 2026
Merged

test(preact-query/ErrorBoundary): replace British 'behaviour' with American 'behavior'#10605
sukvvon merged 1 commit intomainfrom
test/preact-query-error-boundary-fix-british-spelling

Conversation

@sukvvon
Copy link
Copy Markdown
Collaborator

@sukvvon sukvvon commented Apr 28, 2026

🎯 Changes

Replace British spelling behaviour with American behavior in the JSDoc comment of the ErrorBoundary test helper to match the rest of the codebase, where behavior is used in 39 files.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Release Notes

This release contains only internal maintenance updates with no user-visible changes or new features.

  • Chores
    • Minor comment correction in test files.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 03ed45ba-b876-48f4-b0bd-a01da83742f0

📥 Commits

Reviewing files that changed from the base of the PR and between 87f7ccf and 87af4e4.

📒 Files selected for processing (1)
  • packages/preact-query/src/__tests__/ErrorBoundary/ErrorBoundary.ts

📝 Walkthrough

Walkthrough

A comment in the ErrorBoundary test file was updated, changing "react behaviour" to "react behavior" for spelling consistency. No functional changes or logic modifications were made.

Changes

Cohort / File(s) Summary
Comment Spelling Correction
packages/preact-query/src/__tests__/ErrorBoundary/ErrorBoundary.ts
Updated comment text from British to American spelling ("behaviour" → "behavior") in the componentDidCatch method.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A typo caught, a spelling refined,
British English left behind,
Comments polished, clean and bright,
Our ErrorBoundary shines just right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: replacing British spelling with American spelling in the ErrorBoundary test file.
Description check ✅ Passed The description follows the required template structure with all sections completed: Changes section explains the modification, Checklist items are marked as done, and Release Impact correctly identifies this as dev-only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/preact-query-error-boundary-fix-british-spelling

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 28, 2026

View your CI Pipeline Execution ↗ for commit 87af4e4

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 35s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-28 18:04:26 UTC

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 28, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10605

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10605

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10605

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10605

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10605

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10605

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10605

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10605

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10605

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10605

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10605

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10605

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10605

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10605

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10605

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10605

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10605

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10605

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10605

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10605

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10605

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10605

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10605

commit: 87af4e4

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 12.1 KB (0%)
react minimal 9.07 KB (0%)

@sukvvon sukvvon self-assigned this Apr 28, 2026
@sukvvon sukvvon merged commit c5ab5a1 into main Apr 28, 2026
10 checks passed
@sukvvon sukvvon deleted the test/preact-query-error-boundary-fix-british-spelling branch April 28, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant