Update useMutation memoization#166
Merged
tannerlinsley merged 2 commits intoTanStack:masterfrom Feb 27, 2020
Merged
Conversation
Member
|
That multiline suggesting thing is trippy! |
Contributor
Author
|
Yeah that works too. |
Member
|
Yeah, the check is to make sure the mutation is idle or an existing mutation is settled before allowing another one to to be triggered. We may not need it, but I'd like to keep it in until a use case comes along to remove it. |
|
View your CI Pipeline Execution ↗ for commit 3922bf8.
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the issue identified here #165, however I am not sure if the check on the status in the useCallback was needed for a particular reason?
This will allow the mutation function to safely be included in a dependency array of an effect, like below.