Make sure query is refetched specified number of times

[cherniavskii]

If retry is set to 1, I would expect useQuery to try once again after fail

[cherniavskii]

That's weird, tests are passing on my machine :/

[tannerlinsley]

Hmm Travis env issue maybe?

[cherniavskii]

Can you check on your machine?

[tannerlinsley]

Passes 😂

[cherniavskii]

Hey Travis, WTF?

[tannerlinsley]

Wait. I got it to fail locally. Try this:

const rendered = render(<Page />)

    await waitForElement(() => rendered.getByText('error'))

    rendered.debug()

    // query should fail `retry + 1` times, since first time isn't a "retry"
    await waitForElement(() => rendered.getByText('Failed 2 times'))

    rendered.debug()

[tannerlinsley]

Looks like it never flushes the error state because the delay is so small? Thoughts?

[cherniavskii]

To minimize the delay i've set retryDelay to 1.
Will check if it works

[tannerlinsley]

Oooohhhh, I don't think the error status is reached until the very end. It stays in the loading state until the final failure or success.

[tannerlinsley]

And I am pretty sure that is desired from the UI/UX standpoint out of the box.

[cherniavskii]

Yeah, this is fine

[tannerlinsley]

Something still doesn't seem right tho. Try logging out the failureCount in the render function....

[tannerlinsley]

Oh wait. I forgot to build. I think it's good. This is what I have now:

it('should retry specified number of times', async () => {
    const queryFn = jest.fn()
    queryFn.mockImplementation(() => {
      return Promise.reject('Error test')
    })

    function Page() {
      const { status, failureCount } = useQuery('test', queryFn, {
        retry: 1,
        retryDelay: 1,
      })

      return (
        <div>
          <h1>{status}</h1>
          <h2>Failed {failureCount} times</h2>
        </div>
      )
    }

    const rendered = render(<Page />)

    rendered.getByText('loading')

    // query should fail `retry + 1` times, since first time isn't a "retry"
    await waitForElement(() => rendered.getByText('Failed 2 times'))

    rendered.debug()

    expect(queryFn).toHaveBeenCalledTimes(2)
  })

[cherniavskii]

Let's try

[cherniavskii]

Wow, I had to set 50s timeout to make it pass :D

I don't have a better solution for now, at least it works

[tannerlinsley]

That just doesn't seem right though... like something else is wrong.

[tannerlinsley]

Have you tested this in the browser and played with it there?

[cherniavskii]

Yeah https://codesandbox.io/s/spring-tdd-lzlj6

[cherniavskii]

Same with tests - they're passing really fast locally.
That single test takes 4.587s

[tannerlinsley]

That seems really strange. I want to get to the bottom of it.

[tannerlinsley]

I think I found the reason. queryCache is shared among test instances, which are all running in parallel I think...

[tannerlinsley]

Well, no, they're in isolated workers.... What is going on!!!

[iamchanii]

I'd experienced the issue what almost same it. the test passed on my machine but CI failed by timeout. so I had to google and found a solution.

if this project use Jest, would you like to try --maxWorkers=2 flag? it is working for my case without increase timeout seconds. but there is a slight drop in performance.

[cherniavskii]

@iamchanii Unfortunately that didn't help - 9f46b36

[cherniavskii]

queryCache is shared among test instances

I think this is true, looking into this...

[tannerlinsley]

Alright, I found something that might help us debug. Change the queryKey to something other than test (or something unique to the entire test suite) and watch it pass 🤯

[cherniavskii]

Yeah, I've noticed that too
But I found something else. Which is really weird. Would you have time for a call on Zoom?

[tannerlinsley]

Yeah

[cherniavskii]

I've sent you a link in Twitter DM

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 22ccd91.

Command	Status	Duration	Result
nx affected --targets=test:sherif,test:knip,tes...	✅ Succeeded	<1s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	1s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-04-27 00:15:09 UTC