Skip to content

fix(prefetchQuery): Throw error when throwOnError is set #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannerlinsley merged 2 commits into from
Apr 3, 2020
Merged

fix(prefetchQuery): Throw error when throwOnError is set #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ce555c
Add test for throwOnError
kamranayub Apr 3, 2020
e6b05d7
Uncomment throw error
kamranayub Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/queryCache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ export function makeQueryCache() {
instance.onSettled && instance.onSettled(undefined, error)
)

// throw error
throw error
}
}
})()
Expand Down
14 changes: 14 additions & 0 deletions src/tests/queryCache.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,20 @@ describe('queryCache', () => {
expect(second).toBe(first)
})

test('prefetchQuery should throw error when throwOnError is true', async () => {
const fetchFn = () =>
new Promise(() => {
throw new Error('error')
})

await expect(
queryCache.prefetchQuery('key', undefined, fetchFn, {
retry: false,
throwOnError: true,
})
).rejects.toThrow(new Error('error'))
})

test('should notify listeners when new query is added', () => {
const callback = jest.fn()

Expand Down