feat(solid-query): Solid Query Adapter For TanStack Query#4195
feat(solid-query): Solid Query Adapter For TanStack Query#4195ardeora wants to merge 251 commits intoTanStack:betafrom ardeora:solid-query
Conversation
add test support and query client provider tests
add exports to match react query exports
reformat with prettier
- disable rule of hooks in solid-query
fix lint and typecheck errors
conditionally apply babel react preset to packages other than solid-query. apply solid-babel-preset to solid query.
fix npm run build
make tsconfig look like react query tsconifg - add incremental compilation - output types in ./build/lib - allow project references
fix build types.
add the first solid example
fix query types
now we should be able to successfully run npm test on every commit.
get eslint to pass.
Keep comments and better organisation of types by functions
Fix: Typo in useIsFetching
* solid-query: (104 commits) Throw to errorBoundary when options set correctly Making options reactive + added batching tasks Fix infiniteQueries Formatting add createQueries tests run prettier tests Prettier fix for infiniteQueries Added createQueries format with prettier format with prettier almost all create mutation tests passing all infinite query tests passing most infinite query tests passing Small Types Fix for CreateInfiniteQuery Prettifying and removing logs Completed tests and reviewed PR replace react in comment with solid replace instances of test with it ignore some errors in tests add comment about reactive notifyOnChange props more merge fixes ...
rebase on query beta
add solid query docs
add simple and graphql examples
Luke/suspense fixes
add exports from solid preset
- make type come first - make browser valid - make default come last - fix path to solid export - include solid files in files
Thanks to all these amazing folks who helped in making solid-query a reality Co-Authored-By: Luke Murray <34020210+lukesmurray@users.noreply.github.com> Co-Authored-By: Jen Kaplan <25395806+jennyckaplan@users.noreply.github.com> Co-Authored-By: Oscar Beaumont <oscar@otbeaumont.me>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4a6586a:
|
TkDodo
left a comment
TkDodo
left a comment
There was a problem hiding this comment.
wow, this is amazing 🚀
I don't know enough about solid to comment on specifics, but the react-query parts are really awesome ❤️
| @@ -0,0 +1,1737 @@ | |||
| { | |||
There was a problem hiding this comment.
I think there should only be one package-lock.json file at the root of the monorepo. The examples should be listed as a workspace here:
Lines 30 to 56 in ea80700
|
thanks @TkDodo. we can remove the lock file. couple questions. do we need to do anything to get our examples listed on the website with codesandbox integration? do we need all tests passing to get this merged and published on npm? currently there are two failing tests. lastly wanted to confirm any of the changes we made outside the solid-query and examples folders, for instance, changes to rollup.config.ts are ok before we merge. |
I don't know much about the rollup config, I think @DamianOsipiuk does :) |
|
This PR can probably be closed and we can use #4211 instead where I rebased the changes onto |
4 participants
This pull request aims to add the TanStack Query adapter for Solid JS. This pull request will add the following key primitives to the package.
createQuerycreateQueriescreateInfiniteQueriescreateMutationuseIsFetchinguseIsMutatinguseQueryClientQueryClientQueryClientProviderThe adapter docs have been updated as well as examples have been added. Please let me know how I can help get this massive PR accepted in the
betabranchAcknowledgments
The work on solid-query could not have been possible without