Skip to content

refactor(query-core): change QueryMeta and MutationMeta to accept generic types #5412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vojvodics wants to merge 2 commits into from
Closed

refactor(query-core): change QueryMeta and MutationMeta to accept generic types #5412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7a64c4
refactor(query-core): change QueryMeta and MutationMeta to accept gen…
vojvodics May 15, 2023
9dbd964
Change default type value and add ts-expect-error
vojvodics May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions packages/query-core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ export interface InfiniteData<TData> {
pageParams: unknown[]
}

export interface QueryMeta {
export interface QueryMeta<
TQueryFnData = unknown,
TError = unknown,
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
> {
[index: string]: unknown
}

Expand Down Expand Up @@ -101,7 +106,7 @@ export interface QueryOptions<
* Additional payload to be stored on each query.
* Use this property to pass information that can be used in other places.
*/
meta?: QueryMeta
meta?: QueryMeta<TQueryFnData, TError, TData, TQueryKey>
}

export type UseErrorBoundary<
Expand Down Expand Up @@ -544,7 +549,13 @@ export type MutationKey = readonly unknown[]

export type MutationStatus = 'idle' | 'loading' | 'success' | 'error'

export interface MutationMeta {
// @ts-expect-error
export interface MutationMeta<
TData = unknown,
TError = unknown,
TVariables = unknown,
TContext = unknown,
> {
[index: string]: unknown
}

Expand Down Expand Up @@ -585,7 +596,7 @@ export interface MutationOptions<
networkMode?: NetworkMode
cacheTime?: number
_defaulted?: boolean
meta?: MutationMeta
meta?: MutationMeta<TData, TError, TVariables, TContext>
}

export interface MutationObserverOptions<
Expand Down