Skip to content

Feature/memoize combine#7233

Merged
TkDodo merged 3 commits intomainfrom
feature/memoize-combine
Apr 5, 2024
Merged

Feature/memoize combine#7233
TkDodo merged 3 commits intomainfrom
feature/memoize-combine

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Apr 5, 2024

feat(core): memoize result of combine

this PR makes sure to only re-run the combine function if the function itself changed referentially or any of the inputs changed

fixes #6840

TkDodo added 2 commits April 5, 2024 19:14
this PR makes sure to only re-run the combine function if the function itself changed referentially or any of the inputs changed
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 5:50pm

@github-actions github-actions Bot added documentation Improvements or additions to documentation package: react-query package: query-core labels Apr 5, 2024
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6456975. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Apr 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6456975:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Comment thread docs/framework/react/reference/useQueries.md Outdated
@TkDodo TkDodo merged commit 3c31124 into main Apr 5, 2024
@TkDodo TkDodo deleted the feature/memoize-combine branch April 5, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation package: query-core package: react-query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useQueries results are not stable even with memorization attempts

1 participant