fix(eslint-plugin-query): no-shadow lint warning in insertAtPositions()#8142
Merged
TkDodo merged 2 commits intoTanStack:mainfrom Oct 9, 2024
saul-atomrigs:fix/insertAtPositions-no-shadow
Merged
fix(eslint-plugin-query): no-shadow lint warning in insertAtPositions()#8142TkDodo merged 2 commits intoTanStack:mainfrom saul-atomrigs:fix/insertAtPositions-no-shadow
no-shadow lint warning in insertAtPositions()#8142TkDodo merged 2 commits intoTanStack:mainfrom
saul-atomrigs:fix/insertAtPositions-no-shadow
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3910b12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8142 +/- ##
===========================================
+ Coverage 45.41% 88.04% +42.63%
===========================================
Files 200 15 -185
Lines 7456 502 -6954
Branches 1696 187 -1509
===========================================
- Hits 3386 442 -2944
+ Misses 3694 46 -3648
+ Partials 376 14 -362
|
This was referenced Oct 31, 2024
Closed
Closed
This was referenced Nov 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing another
no-shadowlint warning by changing namedatatobaseData.I chose this naming because it is the initial dataset (or foundation) into which the additional elements (subsets) are being built upon.