Skip to content

fix(eslint-plugin-query): handle callable params within exaustive-deps rule#8150

Merged
TkDodo merged 2 commits intoTanStack:mainfrom
pawel-twardziak:bugs/8093-eslint-exhaustive-deps-rule-cant-recognize-getter-in-queryKey
Oct 9, 2024
Merged

fix(eslint-plugin-query): handle callable params within exaustive-deps rule#8150
TkDodo merged 2 commits intoTanStack:mainfrom
pawel-twardziak:bugs/8093-eslint-exhaustive-deps-rule-cant-recognize-getter-in-queryKey

Conversation

@pawel-twardziak
Copy link
Copy Markdown
Contributor

@pawel-twardziak pawel-twardziak commented Oct 8, 2024

Closes #8093

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Oct 9, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eb45788. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Oct 9, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8150

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8150

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8150

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8150

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8150

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8150

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8150

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8150

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8150

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8150

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8150

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8150

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8150

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8150

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8150

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8150

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8150

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8150

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8150

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8150

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8150

commit: eb45788

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (2fe16e5) to head (eb45788).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8150       +/-   ##
===========================================
+ Coverage   45.41%   88.04%   +42.63%     
===========================================
  Files         200       15      -185     
  Lines        7456      502     -6954     
  Branches     1696      187     -1509     
===========================================
- Hits         3386      442     -2944     
+ Misses       3694       46     -3648     
+ Partials      376       14      -362
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 88.04% <100.00%> (+0.21%) ⬆️
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit eb2f9d3 into TanStack:main Oct 9, 2024
This was referenced Oct 31, 2024
Closed
Closed
Merged
@muhiddinjv muhiddinjv mentioned this pull request Oct 31, 2024
Closed
@Bancha-t Bancha-t mentioned this pull request Oct 31, 2024
Open
@Bonniemarie216 Bonniemarie216 mentioned this pull request Oct 31, 2024
Open
This was referenced Nov 2, 2024
Closed
Closed
@jwinr jwinr mentioned this pull request Nov 4, 2024
Merged
@CalPinSW CalPinSW mentioned this pull request Nov 5, 2024
Merged
@GouravNG GouravNG mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: eslint-plugin-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[vue-query]: @tanstack/query/exhaustive-deps rule can't recognize getter in queryKey

2 participants

@pawel-twardziak @TkDodo